Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas: Smartbond: Update LVGL Coordinates #73407

Conversation

ioannis-karachalios
Copy link
Contributor

This commit should take care of the changes introduced in #70541.

This commit should take care of the changes
introduced in zephyrproject-rtos#70541.

Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
@blauret
Copy link
Contributor

blauret commented May 29, 2024

@andrzej-kaczmarek ping

@@ -440,7 +440,7 @@ static void display_smartbond_get_capabilities(const struct device *dev,
* bindings.
*/
capabilities->supported_pixel_formats = DT_INST_PROP(0, pixel_format);
capabilities->current_orientation = DISPLAY_ORIENTATION_NORMAL;
capabilities->current_orientation = DISPLAY_ORIENTATION_ROTATED_180;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the display rotated 180 degrees or is this a work-around to rotate the input device coordinates?

Fyi there will be some changes regarding rotation and input device: #73474

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input. The display panel I am testing with should not be rotated. However, after the changes introduced in #70541 I was no longer able to make it work without playing with the orientation property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the changes proposed in #73474 and this solves the issues I was observing. As such, this PR should no longer be considered valid. @Snevzor can you confirm that this fix will be part of the upcoming LTS 3.7 release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ioannis-karachalios , that is up to @faxe1008 I presume. He is writing a unit test for this as well.

Copy link
Contributor Author

@ioannis-karachalios ioannis-karachalios May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This should be considered a bug so I guess it should be included. I converted this PR to Draft until more info is available. Once again, thanks for notifying me (I did not have time to investigate this).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this beauty: #73556

@ioannis-karachalios
Copy link
Contributor Author

No need to provide any explicit workaround as there is a bug in the LVGL input pointer implementation and that should be fixed in the corresponding PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Display platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants