-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renesas: Smartbond: Update LVGL Coordinates #73407
Renesas: Smartbond: Update LVGL Coordinates #73407
Conversation
This commit should take care of the changes introduced in zephyrproject-rtos#70541. Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
@andrzej-kaczmarek ping |
@@ -440,7 +440,7 @@ static void display_smartbond_get_capabilities(const struct device *dev, | |||
* bindings. | |||
*/ | |||
capabilities->supported_pixel_formats = DT_INST_PROP(0, pixel_format); | |||
capabilities->current_orientation = DISPLAY_ORIENTATION_NORMAL; | |||
capabilities->current_orientation = DISPLAY_ORIENTATION_ROTATED_180; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the display rotated 180 degrees or is this a work-around to rotate the input device coordinates?
Fyi there will be some changes regarding rotation and input device: #73474
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the input. The display panel I am testing with should not be rotated. However, after the changes introduced in #70541 I was no longer able to make it work without playing with the orientation
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ioannis-karachalios , that is up to @faxe1008 I presume. He is writing a unit test for this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. This should be considered a bug so I guess it should be included. I converted this PR to Draft
until more info is available. Once again, thanks for notifying me (I did not have time to investigate this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at this beauty: #73556
No need to provide any explicit workaround as there is a bug in the |
This commit should take care of the changes introduced in #70541.