Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: LVGL: Improve support for hardware display rotation #73556

Closed
wants to merge 4 commits into from
Closed

module: LVGL: Improve support for hardware display rotation #73556

wants to merge 4 commits into from

Conversation

faxe1008
Copy link
Collaborator

@faxe1008 faxe1008 commented May 31, 2024 •
edited
Loading

Originally brought up within #73474 this PR tries to improve the support for hardware based display rotation during runtime.

Since in the past few weeks quite a few bugfixes in regards to pointer input device handling were merged it would be useful to have them properly unit tested.

Test output:

===================================================================
START - test_no_rotation
        Expected: x:20 y:150
        Press:    x:20 y:150
        Release:  x:20 y:150
 PASS - test_no_rotation in 0.001 seconds
===================================================================
START - test_rotation_180
        Expected: x:300 y:90
        Press:    x:300 y:90
        Release:  x:300 y:90
 PASS - test_rotation_180 in 0.001 seconds
===================================================================
START - test_rotation_270
        Expected: x:150 y:300
        Press:    x:150 y:300
        Release:  x:150 y:300
 PASS - test_rotation_270 in 0.001 seconds
===================================================================
START - test_rotation_90
        Expected: x:90 y:20
        Press:    x:90 y:20
        Release:  x:90 y:20
 PASS - test_rotation_90 in 0.001 seconds
===================================================================

@faxe1008 faxe1008 mentioned this pull request May 31, 2024
Closed
@faxe1008 faxe1008 force-pushed the lvgl_input_tests branch 3 times, most recently from 75d73fd to 15e2bae Compare May 31, 2024 12:02
faxe1008
faxe1008 commented May 31, 2024
View reviewed changes
modules/lvgl/include/lvgl_display.h
@@ -49,6 +49,8 @@ int set_lvgl_rendering_cb(lv_disp_drv_t *disp_drv);

void lvgl_flush_display(struct lvgl_display_flush *request);

int lvgl_reload_display_capabilities(void);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that this should not be called while rendering is in progress.

@faxe1008
drivers: display: dummy: Add rotation property
bf6edb2 
Adds the rotation property to the dummy display binding to allow for
setting an initial rotation within tests.

Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
@faxe1008
modules: lvgl: Add lvgl_reload_display_capabilities
cca8234 
Add a method which allows for syncing information within the
display_data struct after the display has been rotated in the
application using `display_set_orientation`. This also makes the
implementation of various input devices unit testable without requiring
a lot of overlay files.

After the current implementation is verified
against unit tests, the reload method will additionally set the
`rotated` flag on the display driver. The LVGL code will then
handle the translation of input devices points to points in the GUI
according to the display rotation.

Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
@faxe1008 faxe1008 marked this pull request as ready for review May 31, 2024 12:37
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: LVGL Light and Versatile Graphics Library Support area: Display labels May 31, 2024
@faxe1008
Copy link
Collaborator Author

Changing this from draft state to review to get some more feedback and hopefully quite a few other pair of eyes on this since the coordinate conversion code has been tricky to handle.

Added @ioannis-karachalios as a reviewer because of #73407

@faxe1008
tests: lib: gui: Add tests for lvgl input devices
190c542 
Adds a test for lvgl input devices in various configurations, like
rotated display, pointer inversions etc.

Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
@faxe1008
modules: lvgl: Sync display rotation to LVGL
5d1112b 
LVGL supports the `rotated` flag on its display drivers. It is used
during input device coordinate processing to translate the physical
touch points to the points in (rendered) GUI space. Previously this was
done by the Zephyr gluecode on system init. With this change it is now
possible to perform runtime rotation of the display, the
`lvgl_reload_display_capabilities` method should be called right after
`display_set_orientation`.

Signed-off-by: Fabian Blatz <fabianblatz@gmail.com>
This was referenced May 31, 2024
Closed
Merged
@Snevzor
Copy link
Contributor

Snevzor commented Jun 1, 2024

Perhaps the test can be expanded to take into account correct rotation initialisation based on the various rotation dts values as well? Like: looping through all dts values and then checking if the input values match. That way the updated LVGL init code is also tested.

@faxe1008 faxe1008 added the DNM This PR should not be merged (Do Not Merge) label Jun 2, 2024
@faxe1008
Copy link
Collaborator Author

faxe1008 commented Jun 2, 2024

@Snevzor neat idea but I fear that this would mean that I'd have to add an overlay on for each rotation and do some messy things with skipping tests I pressume. Could be wrong though :^).

Btw I added a DNM label for now since I want to clarify the discussion around #73360 first.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 2, 2024
@github-actions github-actions bot closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brgl brgl Awaiting requested review from brgl

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@pdgendt pdgendt Awaiting requested review from pdgendt

@ioannis-karachalios ioannis-karachalios Awaiting requested review from ioannis-karachalios

Assignees

@faxe1008 faxe1008

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Display area: LVGL Light and Versatile Graphics Library Support DNM This PR should not be merged (Do Not Merge) Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faxe1008 @Snevzor @zephyrbot