Issue 1221/participant filter #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
requested changes
May 3, 2023
richardolsson
requested changes
May 4, 2023
| @@ -10,12 +10,14 @@ import { ZetkinEvent } from 'utils/types/zetkin'; | |||
|
|
|||
| interface EventParticipantsListProps { | |||
| data: ZetkinEvent; | |||
| filterState: string; | |||
There was a problem hiding this comment.
I think this (and all related references to the same string) should be called filterString, not filterState.
| @@ -41,6 +43,7 @@ const ParticipantsPage: PageWithLayout<ParticipantsProps> = ({ | |||
| eventId, | |||
| orgId, | |||
| }) => { | |||
| const [filterState, setFilterState] = useState<string>(''); | |||
There was a problem hiding this comment.
Change the name here as well.
|
|
||
| type ListType = ZetkinEventParticipant | ZetkinEventResponse; | ||
|
|
||
| //TODO filter cancelled list when API supports it |
There was a problem hiding this comment.
This TODO seems irrelevant here, because there should not need to be any changes to this code when introducing cancelled participants.
| type ListType = ZetkinEventParticipant | ZetkinEventResponse; | ||
|
|
||
| //TODO filter cancelled list when API supports it | ||
| export function filterList( |
There was a problem hiding this comment.
I would change this line:
Suggested change
| export function filterList( | |
| export default function filterParticipants( |
And change the name of this module from participantsFilterUtils.ts to filterParticipants.ts.
richardolsson
approved these changes
May 4, 2023
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements filter with fuzzy search to filter sign up, participants list. It is enable to search input in multiple fields.
Screenshots
Mozilla.Firefox.2023-05-03.14-51-08.mp4
Changes
filterCleared,filteredParticipants,filteredSignUpprops toEventParticipantsListEventParticipantsFilterNotes to reviewer
I gave a different weight to key first_name for now and didn't write any codes for cancelled list!
Related issues
Resolves #1221