-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up foundation for translations page #107
Conversation
webapp/src/app/projects/[projectName]/[languageName]/layout.tsx
Outdated
Show resolved
Hide resolved
5f788f3
to
4017a00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request. I learned a lot by reviewing it and it adds a high value feature: the navigation tree of #73
- There's an important regression about saving translations that I think we should fix before merging, see comment below.
- I think we can implement the parallel loading of the sidebar better with
<Suspense>
in the layout, see comment below. Since that decision is going to have a large effect on coming changes, I think we should at least discuss it before merging this solution. - There are a couple of minor things too, see the comments.
- Last but not fewest, I left a bunch of notes which might or might not interest you.
webapp/src/app/projects/[projectName]/[languageName]/@explorer/page.tsx
Outdated
Show resolved
Hide resolved
webapp/src/app/projects/[projectName]/[languageName]/layout.tsx
Outdated
Show resolved
Hide resolved
webapp/src/app/projects/[projectName]/[languageName]/@explorer/default.tsx
Outdated
Show resolved
Hide resolved
webapp/src/app/projects/[projectName]/[languageName]/@messages/page.tsx
Outdated
Show resolved
Hide resolved
webapp/src/app/projects/[projectName]/[languageName]/@messages/page.tsx
Outdated
Show resolved
Hide resolved
webapp/src/app/projects/[projectName]/[languageName]/@messages/page.tsx
Outdated
Show resolved
Hide resolved
Simplify messages page
f31d5cc
to
7ebd519
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry about dragging this out so much. We're very close to merging now.
Co-authored-by: WULCAN <7813515+WULCAN@users.noreply.github.com>
Used the same "Make macOS scroll bars work like on Linux & Windows" trick as in zetkin/app.zetkin.org#1963 to reproduce the double scrollbar issue and fixed it in 0cd0051 |
I can scroll it by switching focus with the tab key on laptop Chromium. It's not a problem. I'm just not certain what our intention was with toggling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I think there's a small small problem with overflow, see comment below. I think we are ready to merge this.
Nice catch with the keyboard navigation in the mobile layout. Reminded me to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I can't help but find new small problems, see below, but they are not serious enough to block merge.
demo.mp4
There's a few things going on here so here's a quick executive summary.
This is unfinished work. I don't normally like to send a pull request this big, and would have split this up into smaller pieces if I'd been able to find a way to split it into cohesive parts. Here's a sample of some things that are either missing, broken, or that I'm otherwise unsatisfied with.
Thing is, this is actually a complex enough little app that it needed a fair bit of structure adding just to get it into a place where those kinds of individual problems become addressable on an individual basis. So it felt necessary to just do one big first cut PR to get that structure in place, and that's what this is.