Switch to npm #108
Merged
Switch to npm #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had problems with bugs in Yarn 1 regarding package aliases. The developers of Yarn 1 will not accept bug fixes for Yarn 1 anymore as they want users to upgrade to Yarn 4. Since Yarn was created, the features that motivated its use have been added to npm. The only exception being parallel execution but npm has added other features that make it very fast anyway. Here's some perfomance testing results: https://p.datadoghq.eu/sb/d2wdprp9uki7gfks-c562c42f4dfd0ade4885690fa719c818 Yarn introduced lockfiles to ensure that every install results in the exact same file structure in node_modules across all machines. This approach was quickly adopted by npm in npm 5. https://engineering.fb.com/2016/10/11/web/yarn-a-new-package-manager-for-javascript/ https://blog.npmjs.org/post/161081169345/v500.html Yarn introduced Workspaces as an optimization for monorepositories. After a few years, npm adopted that in npm 7. https://classic.yarnpkg.com/blog/2017/08/02/introducing-workspaces/ https://docs.npmjs.com/cli/v7/using-npm/changelog I generated package-lock.json by just running npm install. That command supports and understands yarn.lock.
next build was not happy that npm removed so many swc dependencies when we migrated from yarn, so it added some back again. ⚠ Found lockfile missing swc dependencies, patching... ⚠ Lockfile was successfully patched, please run "npm install" to ensure @next/swc dependencies are downloaded
npm wasn't happy with Next's patch, so it just had to tweak it a little.
henrycatalinismith
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had problems with bugs in Yarn 1 regarding package aliases. See #107
The developers of Yarn 1 will not accept bug fixes for Yarn 1 anymore as they want users to upgrade to Yarn 4.
Since Yarn was created, the features that motivated its use have been added to npm. The only exception being parallel execution but npm has added other features that make it very fast anyway.
Here's some performance testing results: https://p.datadoghq.eu/sb/d2wdprp9uki7gfks-c562c42f4dfd0ade4885690fa719c818
Yarn introduced lockfiles to ensure that every install results in the exact same file structure in node_modules across all machines. This approach was quickly adopted by npm in npm 5.
Yarn introduced Workspaces as an optimization for monorepositories. After a few years, npm adopted that in npm 7.
I generated
package-lock.jsonby just runningnpm install. Then I let Next and npm fight a little about it until they got exhausted and became frienemies. See commit messages for details.