Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO-1133 define amavis white/black list attribute scope #524

Merged
merged 2 commits into from
Jun 18, 2024
Merged

CO-1133 define amavis white/black list attribute scope #524

merged 2 commits into from
Jun 18, 2024

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Jun 17, 2024

@mbarto mbarto requested a review from a team as a code owner June 17, 2024 13:44
@mbarto mbarto requested review from sonersivri, keshavbhatt and drazen04 and removed request for a team June 17, 2024 13:44
@mbarto mbarto mentioned this pull request Jun 17, 2024
Merged
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (27.70% Estimated after merge)
  • Duplications No duplication information (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@keshavbhatt
Copy link
Member

keshavbhatt commented Jun 17, 2024 •
edited
Loading

Hi @mbarto, we also need to run mvn antrun:run@generate-zattr-rights since we modified amavisd-new-attrs.xml file.

@mbarto
Copy link
Contributor Author

mbarto commented Jun 17, 2024

Hi @mbarto, we also need to run mvn antrun:run@generate-zattr-rights since we modified attrs.xml file.

Hi @keshavbhatt we didn't directly modified attrs.xml, but one dedicated to amavis attributes (amavisd-new-attrs.xml). Is this needed also in this case?
thx

@keshavbhatt
Copy link
Member

keshavbhatt commented Jun 17, 2024 •
edited
Loading

Hi @mbarto, we also need to run mvn antrun:run@generate-zattr-rights since we modified attrs.xml file.

Hi @keshavbhatt we didn't directly modified attrs.xml, but one dedicated to amavis attributes (amavisd-new-attrs.xml). Is this needed also in this case? thx

Yes, it seems we need it also here. I just ran the command and it updated ZAttrAccount.java . Probably will not have direct impact but just for completeness and avoid surprises.

@matteobaglini
Copy link
Contributor

@keshavbhatt @mbarto ZAttrAccount.java updated. :-)

@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (27.70% Estimated after merge)
  • Duplications No duplication information (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@matteobaglini matteobaglini merged commit fa24f0e into devel Jun 18, 2024
3 checks passed
@matteobaglini matteobaglini deleted the CO-1133-carbonio-ce-let-user-manage-allowing-and-blocking-addresses branch June 18, 2024 12:57
@matteobaglini matteobaglini mentioned this pull request Jun 27, 2024
Merged
matteobaglini added a commit that referenced this pull request Jul 1, 2024
@matteobaglini @keshavbhatt
@mbarto @aheeva-yuliya
!fix(CO-1244): QAFix stop return 500 for any error and replace it wit…
7f47d06 
…h 422 (#531)

* chore: bump 24.9.0

* CO-1133 define amavis white/black list attribute scope (#524)

* feat: define amavis white/black list attribute scope

* feat: generate get/set/unset methods for amavis white/black lists attributes

---------

Co-authored-by: Matteo Baglini <matteo.baglini@gmail.com>

* chore: [CO-1208] Timestamp-based versioning of packages for devel branch (#527)

* fix: [CO-1180] Remove TNEF converter to prevent .dat attachment duplication (#528)

* feat: remove TnefConverter to ensure application/ms-tnef attachments are handled as a single part without expanding their content
* chore: remove zimbra_converter_enabled_tnef from LC

* fix: stop return 500 for any error and replace it with 422

* test: fixed tests that assumed a 500 error status code from failed SOAP requests

* fix: fixed SoapHttpTransport to handle error 422 properly

---------

Co-authored-by: Keshav Bhatt <keshavnrj@gmail.com>
Co-authored-by: Keshav Bhatt <keshavbhatt@users.noreply.github.com>
Co-authored-by: mbarto <maurobartolomeoli@gmail.com>
Co-authored-by: Yuliya Aheeva <88840377+aheeva-yuliya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonersivri sonersivri sonersivri approved these changes

@matteobaglini matteobaglini matteobaglini approved these changes

@keshavbhatt keshavbhatt keshavbhatt approved these changes

@drazen04 drazen04 drazen04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mbarto @keshavbhatt @matteobaglini @sonersivri @drazen04