fix(CO-1133): fix amavis ldap attrs definition #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobaglini
requested review from
sonersivri,
keshavbhatt,
zextrasGiovanniDefacci,
mbarto,
drazen04,
AlessioCoser,
frisonisland,
matt-zextras and
aheeva-yuliya
and removed request for
a team
mbarto
approved these changes
Jun 27, 2024
keshavbhatt
reviewed
Jun 27, 2024
| } | ||
|
|
||
| @Test | ||
| void attributesSectionProvidesAmavisLists() throws Exception { |
There was a problem hiding this comment.
@matteobaglini this means these attributes are already available for account entry?
There was a problem hiding this comment.
Yes @keshavbhatt, you can already see them, without this modification, in the response of: carbonio prov ga baz@demo.zextras.io | grep amavis.
keshavbhatt
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated by issue
GB-398, PR #524 introduced a regression on LDAP with the addition ofamavisWhitelistSenderandamavisBlacklistSenderattributes tozimbraAccountschema, producing the error:With the PR we remove the two attributes from
zimbraAccountschema and add some tests for theGetInfooperation.