Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-established test runs on Python 3.5 and circumvented pip cert issue #963

Merged
merged 2 commits into from
May 18, 2024

Conversation

andy-maier
Copy link
Member

PR #961 dropped the test runs for Python 3.5 in order to address the Pip certificate issue on Github Actions with Python 3.5.

A comment in actions/setup-python#866 suggested a circumvention. This PR reverts the dropping of test support and uses that circumvention.

@GitCop
Copy link

GitCop commented May 18, 2024

There were the following issues with your Pull Request

  • Commit: a4df549
  • Invalid signoff. Commit message must end with
    Signed-off-by: . <.*>*

Guidelines are available at https://github.com/zhmcclient/zhmc-ansible-modules/blob/master/CONTRIBUTING.rst


This message was auto-generated by https://gitcop.com

@andy-maier andy-maier self-assigned this May 18, 2024
@andy-maier andy-maier added this to the 1.9.0 milestone May 18, 2024
This reverts commit 9b5b1ba.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@coveralls
Copy link

Coverage Status

coverage: 51.344%. first build
when pulling fe7bdb8 on andy/circumvent-py35
into b16d6e4 on master.

@andy-maier andy-maier merged commit 368114b into master May 18, 2024
18 checks passed
@andy-maier andy-maier deleted the andy/circumvent-py35 branch May 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants