Adding coverall.io #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhujinxuan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
Coverage ? 67.47%
=========================================
Files ? 69
Lines ? 5058
Branches ? 1307
=========================================
Hits ? 3413
Misses ? 1213
Partials ? 432
Continue to review full report at Codecov.
|
4 tasks
* update schema customizer to merge marks * update comment
…ylor#1869) * Allow user to use immutable 4.0.0-rc without yarn warning * Fix versions * Fix immutable version to most recent * Fix versions for react
* Fix issue with pasting in IE11 Fixing the issue where dataTransfer or clipboardData are not populated, in IE 11 under event.NativeEvent. Instead, if we are using IE11, use the base event object instead which contains a valid dataTrasnfer/clipboardData object. * Run prettier on code changes
* initial simple decorations (mark-like), many tests added * allow decorators to be set by focus, anchor tags - add tests * handle one more edge case with decorations in hyperscript * apply prettier cleanup * apply linting rules * update changelog * ensure always normalize decoration ranges * reapply prettier after latest adjustments * all operations apply now update decorations with selection * ranges can now be 'atomic', will invalidate if contents change * lint, prettier cleanups * add atomic invalidation tests, update hyperscript usage * fix linter errors * minor cleanup * slight refactor for simplicity * remove a couple superfluous lines * update in response to review * drop unnecessarily committed add'l file * remove the need for explicit anchor, focus prop on decoration tags * update hyperscript use to match latest syntax in ianstormtaylor#1777 * atomic -> isAtomic
* Preparing tests * splitNode replacement * Remove slow splice; replace mergeNode * normalize Leaves * Partially remove characters * Partially remove characters * styling * Fix bugs; almost all characters are replaced * Fixes almost existing tests; preparing adding tests for text * Remove un-necessary check * Empty leaf * fix characters in getMarks * Faster fromJSON * Some corner cases for empty text * Fix naive bug * Supporting empty text with marks * Supporting empty text with marks in hyperscript * changes tests for marks in empty text * Support splitNode marks with empty text * Add tests for splitNode->insert * Faster removeText * Add warning ; remove getMarksAtIndex cache * Remove characters in getInsertMarkAtRange * Adding tests * Change names of tests * Update marks test * Add a test confirm for invalid offsets: * Add test for get active marks between offsets * Fix document * Add testing for insert-text * Better remove text * More sensible marks in empty text * Allow marks of empty text after deleting partially marked text * Add test for removing on partially marked text * chnage test structure * Add test for removeText * Add test for removeText * Avoid conflict between empty marked text and cursor * Simple style fixes * Simple style fixes * Line break fixes * Line break fixes * Annotate the createLeaves * Line breaks in test * Line breaks fix * add add-marks test * add merge test * Fix version update * Remove empty_leaf optimization; optimize of that will be other PRs * Clean up getMarksAtPosition * Fix get-insert-marks-at-range * clean up get-marks-at-position * Fix spaces
|
Close this PR because it absorbs travis test from ian's main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
feature
yarn buildfor testsyarn lintwithyarn lint:codeandyarn lint:documentthen it can be run faster. And it is less confusing when contributors see an error bylint:documentthan justlintWhat's the new behavior?
Sometimes we make careless mistakes just by forgetting to test, or decide to add tests later but forgot. (for example, PR ianstormtaylor#1864 is an example that a test is missing)
Code analysis can help us eliminate these problems, and suggests us which tests are perhaps missing. And new PR contributors can look at the code coverage difference by code.
How does this change work?
Add codeCov as code coverage service. The following is an example about which files/lines are tested and which are not yet tested. When submitting PR, we can check which newly added lines are not yet tested.
For example
Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn prettier.)yarn watch.)Does this fix any issues or need any specific reviewers?
Fixes: #
Reviewers: @