#2941: Cors, accessControlAllowHeaders in option request (prepend pre… #16361
ci.yml
on: pull_request
Matrix: Build and Test
Matrix: Jmh CachedDateHeaderBenchmark
Matrix: Jmh ClientBenchmark
Matrix: Jmh EndpointBenchmark
Matrix: Jmh HttpCollectEval
Matrix: Jmh HttpCombineEval
Matrix: Jmh HttpNestedFlatMapEval
Matrix: Jmh HttpRouteTextPerf
Matrix: Jmh ProbeContentTypeBenchmark
Matrix: Jmh SchemeDecodeBenchmark
Matrix: Jmh ServerInboundHandlerBenchmark
Matrix: Jmh UtilBenchmark
Matrix: Performance Benchmarks (SimpleEffectBenchmarkServer)
Matrix: Performance Benchmarks (PlainTextBenchmarkServer)
Matrix: Unsafe Scoverage
Matrix: Release Drafter
Matrix: Publish Artifacts
Annotations
2 errors and 8 warnings
Release Drafter (ubuntu-latest, 2.13.10, temurin@8)
Resource not accessible by integration
{
name: 'HttpError',
id: '10168612523',
status: 403,
response: {
url: 'https://api.github.com/repos/zio/zio-http/releases',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Tue, 30 Jul 2024 19:33:37 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '5306:2B88A2:1090C0C:10B0FCA:66A94011',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4944',
'x-ratelimit-reset': '1722369095',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '56',
'x-xss-protection': '0'
},
data: {
message: 'Resource not accessible by integration',
documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release',
status: '403'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/zio/zio-http/releases',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"target_commitish":"refs/pull/2943/merge","name":"v3.0.0 🌈","tag_name":"v3.0.0","body":"## Changes\\n\\n- Encode SSE based on HttpContentCodec (#2695) @987Nabil (#2951)\\n- Reduce verbosity of test suites @kyri-petrou (#2979)\\n- Fix WebSockets when request streaming is enabled @kyri-petrou (#2978)\\n- Fixes issue #2971 @gregor-rayman (#2972)\\n- Multi-value segments for PathCodecs @987Nabil (#2959)\\n- Streaming response body content type @eyalfa (#2967)\\n- Fix application shutdown issue when `Server#install` is not called @kyri-petrou (#2966)\\n- Reorg driver layers @eyalfa (#2936)\\n- Override URL\'s toString with encode @guersam (#2939)\\n- Use `Exit.succeed` when body extraction is side-effect free @kyri-petrou (#2938)\\n\\n## 🧰 Maintenance\\n\\n- Update README.md @zio-assistant (#2950)\\n- Use ZIO Assistant to Update Readme @khajavi (#2949)\\n","draft":true,"prerelease":false,"make_latest":"true"}',
request: {}
},
event: {
id: '10168612523',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '#2941 related.\r\n' +
'\r\n' +
'The problem seems to be that the options routes, which handle the cors preflight request, were being added last, so the corsHeaders was not being correctly called ...\r\n' +
'\r\n' +
'```scala\r\n' +
'(routes @@ aspect) :+ optionsRoute\r\n' +
'```\r\n' +
'\r\n' +
'Two tests have been added to CorsSpecs to represent the problem reported by the related issue:\r\n' +
'* OPTIONS request with allowAllHeaders server config\r\n' +
'* OPTIONS request with no headers allowed in server config\r\n'
}
},
number: 2943,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/49655448?v=4',
descriptio
|
Release Drafter (ubuntu-latest, 2.13.10, temurin@8)
HttpError: Resource not accessible by integration
at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '10168612523',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '#2941 related.\r\n' +
'\r\n' +
'The problem seems to be that the options routes, which handle the cors preflight request, were being added last, so the corsHeaders was not being correctly called ...\r\n' +
'\r\n' +
'```scala\r\n' +
'(routes @@ aspect) :+ optionsRoute\r\n' +
'```\r\n' +
'\r\n' +
'Two tests have been added to CorsSpecs to represent the problem reported by the related issue:\r\n' +
'* OPTIONS request with allowAllHeaders server config\r\n' +
'* OPTIONS request with no headers allowed in server config\r\n'
}
},
number: 2943,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/49655448?v=4',
description: 'ZIO — Real World Functional Programming',
events_url: 'https://api.github.com/orgs/zio/events',
hooks_url: 'https://api.github.com/orgs/zio/hooks',
id: 49655448,
issues_url: 'https://api.github.com/orgs/zio/issues',
login: 'zio',
members_url: 'https://api.github.com/orgs/zio/members{/member}',
node_id: 'MDEyOk9yZ2FuaXphdGlvbjQ5NjU1NDQ4',
public_members_url: 'https://api.github.com/orgs/zio/public_members{/member}',
repos_url: 'https://api.github.com/orgs/zio/repos',
url: 'https://api.github.com/orgs/zio'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/zio/zio-http/issues/2943/comments'
},
commits: {
href: 'https://api.github.com/repos/zio/zio-http/pulls/2943/commits'
},
html: { href: 'https://github.com/zio/zio-http/pull/2943' },
issue: {
href: 'https://api.github.com/repos/zio/zio-http/issues/2943'
},
review_comment: {
href: 'https://api.github.com/repos/zio/zio-http/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/zio/zio-http/pulls/2943/comments'
},
self: {
href: 'https://api.github.com/repos/zio/zio-http/pulls/2943'
},
statuses: {
href: 'https://api.github.com/repos/zio/zio-http/statuses/126cb87340a579ca76529b53b01503d69a9efb17'
}
},
active_lock_reason: null,
additions: 67,
assignee: null,
assignees: [],
author_association: 'CONTRIBUTOR',
auto_merge: null,
base: {
label: 'zio:main',
ref: 'main',
repo: {
allow_auto_merge: true,
allow_forking: true,
allow_merge_commit: false,
allow_rebase_merge: true,
allow_squash_merge: true,
allow_update_branch: true,
archive_url: 'https://api.github.com/repos/zio/zio-http/{archive_format}{/ref}',
archived: false,
assignees_url: 'https://api.github.com/repos/zio/zio-http/assignees{/user}',
blobs_url: 'https://api.github.com/repos/zio/zio-http/git/blobs{/sha}',
branches_url: 'https://api.github.com/repos/zio/zio-http/branches{/branch}',
clone_url: 'https://github.com/zio/zio-http.git',
collaborators_url: 'https://api.github.com/repos/zio/zio-http/collaborators{/collaborator}',
comments_url: 'https://api.github.com/repos/zio/zio-http/comments{/number}',
commits_url: 'https://api.github.com/repos/zio/zio-http/commits{/sha}',
|
Release Drafter (ubuntu-latest, 2.13.10, temurin@8)
The following actions use a deprecated Node.js version and will be forced to run on node20: release-drafter/release-drafter@v5. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build and Test (ubuntu-latest, 3.3.3, graal_graalvm@21)
Please remove "components: 'native-image'" from your workflow file. It is automatically included since GraalVM for JDK 17: https://github.com/oracle/graal/pull/5995
|
Build and Test (ubuntu-latest, 2.12.19, graal_graalvm@21)
Please remove "components: 'native-image'" from your workflow file. It is automatically included since GraalVM for JDK 17: https://github.com/oracle/graal/pull/5995
|
Performance Benchmarks (PlainTextBenchmarkServer) (ubuntu-latest, 2.13.14, temurin@8)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Performance Benchmarks (PlainTextBenchmarkServer) (ubuntu-latest, 2.13.14, temurin@8)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Performance Benchmarks (SimpleEffectBenchmarkServer) (ubuntu-latest, 2.13.14, temurin@8)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Performance Benchmarks (SimpleEffectBenchmarkServer) (ubuntu-latest, 2.13.14, temurin@8)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build and Test (ubuntu-latest, 2.13.14, graal_graalvm@21)
Please remove "components: 'native-image'" from your workflow file. It is automatically included since GraalVM for JDK 17: https://github.com/oracle/graal/pull/5995
|