Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drop dependency on scala-collection-compat when using Scala >= 2.13 #1275

Merged
merged 1 commit into from
May 29, 2022

Conversation

jpablo
Copy link
Contributor

@jpablo jpablo commented May 29, 2022

This is only an issue for Scala 3 projects that depend on Scala 2 projects using scala-collection-compat_2.13 (such as scalameta).

In such cases there's an sbt conflict:

[error] Modules were resolved with conflicting cross-version suffixes ...
[error]    org.scala-lang.modules:scala-collection-compat _3, _2.13

As scalameta is not available yet for Scala 3, there's no easy solution for now.

@jpablo jpablo changed the base branch from main to zio-series/2.x May 29, 2022 04:30
@tusharmath tusharmath enabled auto-merge (squash) May 29, 2022 05:21
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2022

Codecov Report

Merging #1275 (4c77373) into zio-series/2.x (c29b787) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           zio-series/2.x    #1275   +/-   ##
===============================================
  Coverage           58.11%   58.11%           
===============================================
  Files                  74       74           
  Lines                2466     2466           
  Branches               73       73           
===============================================
  Hits                 1433     1433           
  Misses               1033     1033           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29b787...4c77373. Read the comment docs.

@tusharmath tusharmath changed the title Don't depend on scala-collection-compat when using Scala >= 2.13 Fix: Drop dependency on scala-collection-compat when using Scala >= 2.13 May 29, 2022
@tusharmath tusharmath merged commit fde3050 into zio:zio-series/2.x May 29, 2022
@tusharmath
Copy link
Collaborator

Can u create a PR wrt main also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants