Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on scala-collection-compat when using Scala >= 2.13 #1276

Merged
merged 1 commit into from
May 30, 2022

Conversation

jpablo
Copy link
Contributor

@jpablo jpablo commented May 30, 2022

Counterpart of #1275

@codecov-commenter
Copy link

Codecov Report

Merging #1276 (48fb9e3) into main (eff1be2) will increase coverage by 0.14%.
The diff coverage is 86.53%.

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   59.48%   59.63%   +0.14%     
==========================================
  Files          69       70       +1     
  Lines        2446     2450       +4     
  Branches       81       70      -11     
==========================================
+ Hits         1455     1461       +6     
+ Misses        991      989       -2     
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/http/Http.scala 63.80% <0.00%> (ø)
zio-http/src/main/scala/zhttp/http/package.scala 100.00% <ø> (ø)
zio-http/src/main/scala/zhttp/http/Path.scala 79.16% <79.16%> (ø)
zio-http/src/main/scala/zhttp/http/Scheme.scala 70.96% <87.50%> (+2.00%) ⬆️
zio-http/src/main/scala/zhttp/http/Cookie.scala 82.48% <100.00%> (ø)
...io-http/src/main/scala/zhttp/http/PathSyntax.scala 100.00% <100.00%> (ø)
zio-http/src/main/scala/zhttp/http/URL.scala 86.95% <100.00%> (ø)
...ain/scala/zhttp/service/ServerResponseWriter.scala 88.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc17a70...48fb9e3. Read the comment docs.

@tusharmath tusharmath enabled auto-merge (squash) May 30, 2022 03:47
@tusharmath tusharmath merged commit c192286 into zio:main May 30, 2022
@tusharmath
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants