By default set client idle timeout #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having no idle timeout by default is not the right choice. Most modern environments (e.g. every cloud, every proxy) forget about idle connections fairly quickly. For example, I have worked with proxies that forgot about connections after an idle time of as low as 90 seconds. In this change we set the default idle time to 50 seconds.
erikvanoosten
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
=======================================
Coverage 63.24% 63.24%
=======================================
Files 136 136
Lines 7046 7046
Branches 1219 1219
=======================================
Hits 4456 4456
Misses 2590 2590
☔ View full report in Codecov by Sentry. |
guizmaii
reviewed
Aug 6, 2023
| @@ -608,7 +608,7 @@ object ZClient { | |||
| localAddress = None, | |||
| addUserAgentHeader = true, | |||
| webSocketConfig = WebSocketConfig.default, | |||
| idleTimeout = None, | |||
| idleTimeout = Some(50.seconds), | |||
There was a problem hiding this comment.
Just in case a virtual network or proxy decides to set the idle time out to 60 seconds, we need something even lower than that. On the other hand, it should be as high as possible. 50 is a random compromise I picked.
vigoo
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having no idle timeout by default is not the right choice. Most modern environments (e.g. every cloud, every proxy) forget about idle connections fairly quickly. For example, I have worked with proxies that forgot about connections after an idle time of as low as 90 seconds.
Having to find this out in production is not a good developer experience.
In this change we set the default idle time to 50 seconds.