Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default set client idle timeout #2371

Merged
merged 1 commit into from
Aug 12, 2023
Merged

By default set client idle timeout #2371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zio-http/src/main/scala/zio/http/ZClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ object ZClient {
localAddress = None,
addUserAgentHeader = true,
webSocketConfig = WebSocketConfig.default,
idleTimeout = None,
idleTimeout = Some(50.seconds),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 50 and not 60?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case a virtual network or proxy decides to set the idle time out to 60 seconds, we need something even lower than that. On the other hand, it should be as high as possible. 50 is a random compromise I picked.

connectionTimeout = None,
)
}
Expand Down