Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill-finagle-mysql: add connection init sql support #1854

Closed

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented May 11, 2020

Problem

From finagle 20.4.1, finagle-mysql support connection init request. It is same feature with HikariCP connection-init-sql.

image

Currently FinagleMysqlContextConfig doesn't support this feature.

Solution

Add connectionInitSql config for FinagleMysqlContextConfig.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2022

CLA assistant check
All committers have signed the CLA.

@juliano
Copy link
Collaborator

juliano commented Jun 28, 2023

Closed once finagle modules have been dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants