-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scala 2.12 to 2.12.17 && Drop quill-finagle-mysql
and quill-finagle-postgres
modules
#2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
update_scala_212
branch
2 times, most recently
from
June 1, 2023 11:31
4415c6c
to
403c16a
Compare
guizmaii
force-pushed
the
update_scala_212
branch
2 times, most recently
from
June 1, 2023 12:47
7a998f6
to
ed6169a
Compare
guizmaii
force-pushed
the
update_scala_212
branch
from
June 1, 2023 13:06
ed6169a
to
fbff735
Compare
guizmaii
changed the title
Update Scala 2.12 to 2.12.17
Update Scala 2.12 to 2.12.17 && Drop Jun 1, 2023
quill-finagle-mysql
and quill-finagle-postgres
modules
guizmaii
force-pushed
the
update_scala_212
branch
from
June 1, 2023 14:16
b421cde
to
d53df22
Compare
guizmaii
commented
Jun 1, 2023
Comment on lines
+647
to
+650
(CrossVersion.partialVersion(scalaVersion.value) match { | ||
case Some((2, 12)) => "org.scala-lang.modules" %% "scala-java8-compat" % "0.8.0" | ||
case _ => "org.scala-lang.modules" %% "scala-java8-compat" % "1.0.2" | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Akka uses 0.8.0
in its 2.12 version and 1.0.x
in its 2.13 version.
These versions are not binary compatible
deusaquilus
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
joelsonoda
pushed a commit
to joelsonoda/zio-quill
that referenced
this pull request
Jun 27, 2023
…-finagle-postgres` modules (zio#2756) * Update Scala 2.12 to 2.12.17 * clean * Drop `quill-finagle-mysql` and `quill-finagle-postgres` module
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might have an issue:
If we want to update Scala 2.12 we can't continue to provide the
quill-finagle-mysql
andquill-finagle-postgres
modules asfinagle-mysql
andfinagle-postgres
are still using dependencies that are binary incompatible with Scala 2.12.17.finagle-postgres
doesn't seem to be maintained anymore. Last release in 2021: https://github.com/finagle/finagle-postgres/releasesfinagle-mysql
seems to still be maintained a bit. Last release in December last year: https://mvnrepository.com/artifact/com.twitter/finagle-mysqlIssue with
finagle-mysql
and Scala 2.12.17:issue with `` and Scala 2.12.17:
To reproduce, uncomment these modules declaration on the
build.sbt
and run in sbt: