Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala 2.12 to 2.12.17 && Drop quill-finagle-mysql and quill-finagle-postgres modules #2756

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

guizmaii
Copy link
Member

@guizmaii guizmaii commented Jun 1, 2023

We might have an issue:
If we want to update Scala 2.12 we can't continue to provide the quill-finagle-mysql and quill-finagle-postgres modules as finagle-mysql and finagle-postgres are still using dependencies that are binary incompatible with Scala 2.12.17.

finagle-postgres doesn't seem to be maintained anymore. Last release in 2021: https://github.com/finagle/finagle-postgres/releases
finagle-mysql seems to still be maintained a bit. Last release in December last year: https://mvnrepository.com/artifact/com.twitter/finagle-mysql

Issue with finagle-mysql and Scala 2.12.17:

[error] (quill-codegen-tests / Test / managedSources) java.lang.IllegalStateException: Failed to load data source for config: 'Config(SimpleConfigObject({"dataSource":{"url":"jdbc:h2:file:./codegen_test.h2;DB_CLOSE_ON_EXIT=TRUE","user":"sa"},"dataSourceClassName":"org.h2.jdbcx.JdbcDataSource"}))'
[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error]         * org.scala-lang.modules:scala-parser-combinators_2.12:2.1.1 (early-semver) is selected over {1.1.2}
[error]             +- org.apache.spark:spark-catalyst_2.12:3.4.0         (depends on 2.1.1)
[error]             +- com.twitter:util-core_2.12:22.12.0                 (depends on 1.1.2)

issue with `` and Scala 2.12.17:

[error] (quill-codegen-tests / Test / managedSources) java.lang.IllegalStateException: Failed to load data source for config: 'Config(SimpleConfigObject({"dataSource":{"url":"jdbc:h2:file:./codegen_test.h2;DB_CLOSE_ON_EXIT=TRUE","user":"sa"},"dataSourceClassName":"org.h2.jdbcx.JdbcDataSource"}))'
[error] (update) found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[error] 
[error]         * org.scala-lang.modules:scala-parser-combinators_2.12:2.1.1 (early-semver) is selected over 1.1.2
[error]             +- org.apache.spark:spark-catalyst_2.12:3.4.0         (depends on 2.1.1)
[error]             +- com.twitter:util-core_2.12:21.3.0                  (depends on 1.1.2)

To reproduce, uncomment these modules declaration on the build.sbt and run in sbt:

++ 2.12.x Test/compile

@guizmaii guizmaii marked this pull request as draft June 1, 2023 08:36
@guizmaii guizmaii force-pushed the update_scala_212 branch 2 times, most recently from 4415c6c to 403c16a Compare June 1, 2023 11:31
@guizmaii guizmaii force-pushed the update_scala_212 branch 2 times, most recently from 7a998f6 to ed6169a Compare June 1, 2023 12:47
@guizmaii guizmaii force-pushed the update_scala_212 branch from ed6169a to fbff735 Compare June 1, 2023 13:06
@guizmaii guizmaii changed the title Update Scala 2.12 to 2.12.17 Update Scala 2.12 to 2.12.17 && Drop quill-finagle-mysql and quill-finagle-postgres modules Jun 1, 2023
@guizmaii guizmaii marked this pull request as ready for review June 1, 2023 14:14
@guizmaii guizmaii force-pushed the update_scala_212 branch from b421cde to d53df22 Compare June 1, 2023 14:16
Comment on lines +647 to +650
(CrossVersion.partialVersion(scalaVersion.value) match {
case Some((2, 12)) => "org.scala-lang.modules" %% "scala-java8-compat" % "0.8.0"
case _ => "org.scala-lang.modules" %% "scala-java8-compat" % "1.0.2"
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akka uses 0.8.0 in its 2.12 version and 1.0.x in its 2.13 version.
These versions are not binary compatible

Copy link
Collaborator

@deusaquilus deusaquilus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@guizmaii guizmaii merged commit 769acf9 into zio:master Jun 1, 2023
@guizmaii guizmaii deleted the update_scala_212 branch June 1, 2023 16:10
joelsonoda pushed a commit to joelsonoda/zio-quill that referenced this pull request Jun 27, 2023
…-finagle-postgres` modules (zio#2756)

* Update Scala 2.12 to 2.12.17

* clean

* Drop `quill-finagle-mysql` and `quill-finagle-postgres` module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants