Remove ScalaJS support #2869
Merged
Remove ScalaJS support #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
sbt-ci-release_no_js
branch
from
3748ffa to
698b470
Compare
guizmaii
force-pushed
the
sbt-ci-release_no_js
branch
from
9224241 to
92640f1
Compare
guizmaii
commented
Sep 20, 2023
| implicit def dummyDecoder[T] = | ||
| (idx: Int, row: ResultRow, session: Session) => Messages.fail("quill decoders are not used for spark") | ||
| implicit def dummyDecoder[T]: (Index, ResultRow, ResultRow) => Nothing = | ||
| (_: Int, _: ResultRow, _: Session) => Messages.fail("quill decoders are not used for spark") |
guizmaii
commented
Sep 20, 2023
| @@ -47,7 +47,7 @@ trait QuillSparkContext extends Context[SparkDialect, Literal] with Encoders wit | |||
| val idiom = SparkDialect | |||
| val naming = Literal | |||
|
|
|||
| private implicit def datasetEncoder[T] = | |||
| private implicit def datasetEncoder[T]: (Index, Dataset[T], List[Binding], ResultRow) => List[Binding] = | |||
guizmaii
commented
Sep 20, 2023
| @@ -15,7 +15,7 @@ class MirrorIdiomSpec extends Spec { | |||
|
|
|||
| import MirrorIdiom._ | |||
|
|
|||
| implicit val naming = Literal | |||
| implicit val naming: Literal = Literal | |||
guizmaii
commented
Sep 20, 2023
| @@ -9,7 +9,7 @@ object MirrorContexts { | |||
| object testAsyncContext extends AsyncMirrorContext(MirrorIdiom, Literal) with TestEntities { | |||
|
|
|||
| // hack to avoid Await.result since scala.js doesn't support it | |||
| implicit val immediateEC = new ExecutionContext { | |||
| implicit val immediateEC: ExecutionContext = new ExecutionContext { | |||
guizmaii
commented
Sep 20, 2023
| @@ -17,7 +17,7 @@ object DefaultNodeCatalog extends NodeCatalog { | |||
|
|
|||
| private val logger = Logger(LoggerFactory.getLogger(this.getClass)) | |||
|
|
|||
| implicit def nodeToOpt(dagNode: DagNode) = Some(dagNode) | |||
| implicit def nodeToOpt(dagNode: DagNode): Option[DagNode] = Some(dagNode) | |||
guizmaii
commented
Sep 20, 2023
| @@ -13,7 +13,7 @@ abstract class CodegenSpec extends AnyFreeSpec with SchemaMaker { | |||
| type Prefix <: ConfigPrefix | |||
| val prefix: Prefix | |||
|
|
|||
| implicit def regToOption[T](t: T) = Some(t) | |||
| implicit def regToOption[T](t: T): Option[T] = Some(t) | |||
guizmaii
commented
Sep 23, 2023
| @@ -6,6 +6,7 @@ on: | |||
| branches: | |||
| - master | |||
| - sbt-ci-release | |||
| - sbt-ci-release_no_js | |||
There was a problem hiding this comment.
TODO @guizmaii: TO REMOVE
juliano
pushed a commit
that referenced
this pull request
Sep 24, 2023
…elated code && Rename `io.getquill.context.zio` package to `io.getquill.context.qzio` in the `jasync` modules (#2866) * Migrate to sbt-ci-release * Migrate to sbt-ci-release * Fix sbt * Don't wait for build * Speed up release by splitting per Scala version * Improve memory usage * clean * fix scala version * clean * fix CI * Improve memory usage * clean * scalafmt * try fix scaladoc * try fix scaladoc * try fix Scala 2.12 build * Don't publish `quill-codegen-tests` module * Revert "try fix Scala 2.12 build" This reverts commit eb622c7. * Don't publish `quill-codegen-tests` module * Don't publish Scala JS modules * Fix Scala Steward configuration (#2868) * Remove ScalaJS support (#2869) * Remove ScalaJS support * run publish * fix compilation * fix compilation * fix CI * Fix Scala 2.12 doc generation * Clean CI * clean * clean * scalafmt * Fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was added here: #452
Needs: