-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scala.js support #452
scala.js support #452
Conversation
.settings(libraryDependencies ++= Seq( | ||
"com.typesafe" % "config" % "1.3.0", | ||
"com.typesafe.scala-logging" %% "scala-logging" % "3.4.0", | ||
"org.scala-lang" % "scala-reflect" % scalaVersion.value | ||
)) | ||
.jsSettings( | ||
coverageExcludedPackages := ".*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scala.js builds don't support coverage.
will this make the build slower when using sbt locally? is it possible to easily disable cross-compiling for development purpose? |
I've changed the sbt build to exclude the js compilation by default. The ci build will set |
Please, install and run [docker-machine-nfs](https://github.com/adlogix/docker-machine-nfs). | ||
It will change the default file sharing of your [docker-machine](https://docs.docker.com/machine/) | ||
from Virtual Box Shared Folders to NFS, which is a lot faster. | ||
Use [docker for mac](https://docs.docker.com/engine/installation/mac/#/docker-for-mac). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 a lot better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part with docker-machine
and address 192.168.99.100
can be omitted as well. The new native docker for Mac uses localhost address, just like Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still necessary, I have to run those commands if I'm running the build "outside" the container.
Suggestion from a reddit comment: https://www.w3.org/TR/webdatabase/ instead of Node |
@fwbrasil that specification was stopped a long time ago. The W3C did not want to be tight to the SQlite implementation. |
Fixes #18
Problem
Quill's core and its sql extension are basically "pure" Scala code. They could be used by Scala.js applications. See slick/slick#1313 for some examples of use cases.
Solution
Cross-compile
quill-core
andquill-sql
to Scala.js.Notes
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers