fix infinity loop in RedisUri, add tests for ClusterPartitionOutput #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maizy
force-pushed
the
iss970-fix-redis-uri-constructor
branch
from
64cb20c to
400b75a
Compare
|
Looks like the old I'll try to update testcontainers, as far as I know the new version knows how to use |
|
|
|
I've made a separate PR to update testcontainers #985 |
|
@maizy please rebase |
maizy
force-pushed
the
iss970-fix-redis-uri-constructor
branch
from
400b75a to
ca001d1
Compare
mijicd
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #970
Bug in RedisUri was introduced when adding TLS support (#930).
RedisUri.apply(String)constructor called itself after building connection URI string, causing cluster spec to hang.Unfortunately I haven't managed to run cluster spec locally yet, but now it's another problem, possibly with NATted network environment inside the test cluster.