Implement Parallel Finalizers Mask #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in parallel operations such as
zipWithParif the workflows run in parallel each add finalizers those finalizers will be run sequentially in the reverse order of being added unlessparallelFinalizersis explicitly used to indicate that finalizers should be run in parallel. This can introduce an unnecessary dependency between finalizers.This PR improves this by implementing a
parallelFinalizersMaskoperator which indicates that finalizers should be run in parallel but also provides arestorefunction that can be used to restore the original execution strategy for finalizers. It then uses this inZIO#zipWithParandZIO.collectAllPar, as well as making similar changes inZLayer#++.