Fix new bing search api #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop changes to InterpreterInstanceImpl
…LiteralColumnTagger
…won't be fixed in the first iteration.
…won't be fixed in the first iteration.
Conflicts: odalic/src/main/java/cz/cuni/mff/xrg/odalic/tasks/results/Result.java odalic/src/test/java/cz/cuni/mff/xrg/odalic/tasks/executions/InterpreterExecutionBatch.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Tomáš Knap's instructions I am making a pull request from our fork, where we've just added support for the version 5 of the Bing Search API.
The relevant part is the sti-websearch module (it was re-factored in the process and the seemingly unnecessary support for multiple and outdating keys was also dropped) and naturally the websearch.properties configuration, which was also slightly modified.
Our forks have diverged a lot so I am making no attempts to reconcile any of the differences. Just pick what you need from the sti-websearch.
Do not hesitate to contact me in case you have any question.