Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to show GitInfo in footer #126

Closed
ottlinger opened this issue Mar 27, 2023 · 2 comments
Closed

Provide option to show GitInfo in footer #126

ottlinger opened this issue Mar 27, 2023 · 2 comments
Assignees

Comments

@ottlinger
Copy link
Contributor

Following

Personally I'd prefer a git hash that is shown if
--enableGitInfo is used or config.toml contains
enableGitInfo=true
similar to the link shown depending on the configuration option hidedesignbyline.

Any thoughts on that? (Before I start with a PR) :)

Thanks

@ottlinger ottlinger changed the title Option to show GitInfo in footer Provide option to show GitInfo in footer Mar 27, 2023
@zjedi
Copy link
Owner

zjedi commented Mar 27, 2023

Sounds like a feature relevant mostly to tech savvy people, I think it should be opt-in. enableGitInfo=true with default value false sounds good to me. I don't have strong views on this, do it the way that fits you best :)

zjedi added a commit that referenced this issue Mar 30, 2023
#126: Provide option to show GitInfo in footer
@ottlinger
Copy link
Contributor Author

Thanks.

zjedi pushed a commit that referenced this issue Mar 31, 2023
* #126: Add issue to changelist

* #128: Add base CHANGELOG

* Issue #128, #126: Add first entries

* Link to issue

* #128: Adapt contribution guidelines to new Changelog

* #128: Tweak README to include changelog

* #128: Fix link to changes

* Issues #126, #129, #128: Add changelog entries

* #128: Add entries for past PRs

* #128: Remove extra section to changelog

* #128: Rename as suggested

* #128: Make link to changelog relative to work in forks/PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants