Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reference icons in external links #129

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Add ability to reference icons in external links #129

merged 3 commits into from
Mar 30, 2023

Conversation

ottlinger
Copy link
Contributor

@ottlinger ottlinger commented Mar 29, 2023

Add new parameter to external links to reference and print icons in front of external links.

Add example how to reference icons in external links
@ottlinger ottlinger marked this pull request as ready for review March 29, 2023 19:55
@ottlinger
Copy link
Contributor Author

@zjedi not sure if there is a nicer (more Go-like) way to reference/call the other shortcode, but copy&paste works locally.

@zjedi
Copy link
Owner

zjedi commented Mar 29, 2023

This looks very useful, thanks for contributing!

@zjedi not sure if there is a nicer (more Go-like) way to reference/call the other shortcode, but copy&paste works locally.

As long as it works it's fine in my eyes :) You can have look at https://gohugo.io/templates/shortcode-templates/ for more details on custom shortcodes.

The only imperfection in my eyes is having the space between icon and text underlined - but that would complicate the implementation, not a big deal :)
image

@ottlinger
Copy link
Contributor Author

@zjedi I've added the space as the icon is glued to the text otherwise. Would you think a   would be a better solution? Thanks.

@zjedi
Copy link
Owner

zjedi commented Mar 30, 2023

One can alternatively use extlink and icon separately, if it's not required to have the icon linkeable

@zjedi zjedi merged commit dd85215 into zjedi:master Mar 30, 2023
@ottlinger
Copy link
Contributor Author

@zjedi strangely I'm unable to fetch the latest commits in my project's submodule .... hopefully it only is a caching issue on Github, but will try again in the evening.

zjedi pushed a commit that referenced this pull request Mar 31, 2023
* #126: Add issue to changelist

* #128: Add base CHANGELOG

* Issue #128, #126: Add first entries

* Link to issue

* #128: Adapt contribution guidelines to new Changelog

* #128: Tweak README to include changelog

* #128: Fix link to changes

* Issues #126, #129, #128: Add changelog entries

* #128: Add entries for past PRs

* #128: Remove extra section to changelog

* #128: Rename as suggested

* #128: Make link to changelog relative to work in forks/PRs
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants