Feat/v1 #5
Merged
Feat/v1 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleel
force-pushed
the
feat/v1
branch
9 times, most recently
from
3eb6319
to
6293b78
Compare
saleel
force-pushed
the
feat/v1
branch
3 times, most recently
from
87035a1
to
349472a
Compare
This reverts commit 3dadd1b.
…ail-wallet into relayer/onboarding
…into relayer/onboarding
…into relayer/onboarding
* Add templates it includes slippage param for uniswap. * Add unit tests for uni extension templates 1 through 4. * Process sequentially for each templateIndex. * Change slippageBasisPoints -> defaultSlippagePoints. * Update a comment for approval mock for usdcToken. * Add 2 tests using slippage and sqrt price limit params into integration testing. * Add integration test for sqrt price limit. * Add UniswapExtensionCommandTest.json. * Update sqrt price limit separated by spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.