Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1180

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix typo #1180

merged 1 commit into from
Feb 14, 2023

Conversation

tomByrer
Copy link
Contributor

Sorry brother!

Sorry brother!
@rybak
Copy link
Contributor

rybak commented Feb 14, 2023

@zloirock and @methbkts would you be interested in a bigger PR to proof-read and fix grammar in docs/2023-02-14-so-whats-next.md and README.md?

@zloirock
Copy link
Owner

@rybak why not? Thanks.

@zloirock zloirock merged commit 8497b3c into zloirock:master Feb 14, 2023
@Luashine
Copy link
Contributor

Luashine commented Feb 14, 2023

@rybak progress? If I get no reply, I will begin from the start and finish a PR tonight. I will begin my proof-reading part with Ensuring compatibility for the whole Web for now.

Update: I've finished that part and will continue from the start until that chapter.

@rybak
Copy link
Contributor

rybak commented Feb 15, 2023

@Luashine hello. You can find my work in progress here: master...rybak:core-js:grammar-fixes. I've gone through everything until "Roadmap".

@Luashine
Copy link
Contributor

@rybak I'm literally done :) I will post the PR as is and go to bed, if there're any improvements to be made then feel free to do whatever improve upon further or undo my changes.

Sorry, I've checked out your fork before but I don't think I looked at branches before I commented above. That's in case you had already started working by then.

@rybak
Copy link
Contributor

rybak commented Feb 15, 2023

@Luashine

@rybak I'm literally done :) I will post the PR as is and go to bed, if there're any improvements to be made then feel free to do whatever improve upon further or undo my changes.

Thank you for working on this.

Sorry, I've checked out your fork before but I don't think I looked at branches before I commented above. That's in case you had already started working by then.

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants