Proof-reading of "So Whats Next" #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some places in post "2023-02-14-so-whats-next.md" use spaced hyphens, some use spaced m-dashes. Replace usages of spaced hyphen (-) with more appropriate m-dash (—) for consistency and readability.
The post "2023-02-14-so-whats-next.md" uses a combination of straight
double quotes ("") and curly double quotes (“”). Replace the only usage
of curly ones with straight double quotes.
The post "2023-02-14-so-whats-next.md" uses a combination of straight
single quotes (') and curly single quotes (’). Replace all usages of
curly ones with straight single quotes.
Fix wording in 2023-02-14-so-whats-next.md: add missing words, replace words, rearrange sentences, etc.
I was pretty liberal in my edits, tried to understand author's intentional words and rephrase them better in some places.
Luashine
changed the title
rybak
reviewed
Feb 15, 2023
There was a problem hiding this comment.
First of all, thank you for the PR. I don't have bandwidth right now to look through the changes, but I noticed that you've updated only file docs/2023-02-14-so-whats-next.md. At the moment the same content is included in README.md, which should be updated as well.
|
Thanks. I'm in the hospital all this day for a checkup, so I'll check it later. |
zloirock
reviewed
Feb 18, 2023
zloirock
reviewed
Feb 18, 2023
zloirock
reviewed
Feb 18, 2023
zloirock
reviewed
Feb 18, 2023
zloirock
reviewed
Feb 18, 2023
zloirock
reviewed
Feb 18, 2023
Changes up to 23:28, excluding the donations chapter
… rybak/grammar-fixes Since this is a natural text with multiple options, this merge commit actually changes some sentences to accomodate both suggestions. The dash changes were kept where possible. The single- and double-quote changes were not respected during merge, because I did not read Rybak's commit messages; they're indeed inconsistent.
Fix up after the previous merge. This includes the left over m-dash, single quotes, double-quotes.
|
(CI fails because of Node 19.7 bug, nodejs/node#46755) |
zloirock
approved these changes
Feb 23, 2023
|
Thanks a lot -) |
This was referenced Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pretty liberal in my edits, tried to understand author's intentional words and rephrase them better in some places.
@rybak just notified me that he on it as well at the moment, but I'm creating this PR and calling it a day (or night) ;) Overall I'm surprised that only 3 people decided to help so far... Or am I? 🎶
TODO:
Discussed and implemented already:
EDIT: Так, остались записки в блокноте:
line 196: "это + и это" будет корректнее перевести (как минимум) как It is, если не усложнять и не дописывать предложения.
На заметку: Тире в таком количестве не используются в других языках, они, скорее, атипичны. Больше запятых, простых предложений, акцента посредством двоеточий.
Как предложение по-русски, особенно часть про desire? Если конструкция "было бы желание", то надо переписать предложение.
"the most of" тут о чем?
На L56 специально добавила символ процента, для наглядности.