Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split toolbar #11

Merged
merged 8 commits into from
Nov 14, 2023
Merged

Split toolbar #11

merged 8 commits into from
Nov 14, 2023

Conversation

zoccoler
Copy link
Owner

This closes #8

  • Extra buttons go in separated toolbar below matplotlib toolbar
  • Second toolbar imported from nap-plot-tools

example how to make a toolbar with qtpy with checkable replaceable icons
…destroyed (by closing widget)

Fixes this error if re-openning plotter after closing it.
ValueError: Can not reset the axes. You are probably trying to re-use an artist in more than one Axes which is not supported

Also, remove second toolbar and use qt made one
@zoccoler zoccoler self-assigned this Nov 14, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d62bf80) 44.99% compared to head (240684c) 40.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/napari_signal_selector/interactive.py 54.71% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   44.99%   40.22%   -4.77%     
==========================================
  Files           7        7              
  Lines         629      522     -107     
==========================================
- Hits          283      210      -73     
+ Misses        346      312      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoccoler zoccoler merged commit b6ed897 into main Nov 14, 2023
10 checks passed
@zoccoler zoccoler deleted the split_toolbar branch November 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a second matplotlib plotter throws an error
2 participants