-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifier: Add support for inactive (private) workflows #2940
Conversation
207c3fc
to
986d85e
Compare
Here's our previous discussion about the Panoptes user resource in the classifier. |
7c50b5a
to
673c862
Compare
513f65b
to
6fac5b9
Compare
cfa5390
to
ccd713f
Compare
ccd713f
to
261e5d6
Compare
Adding myself to the PR because this is related to some work I'm doing with the Solar Jets project and I'd like to be familiar with these updates. I will add a review, but because I'm just walking into this, it may be a good idea to have @shaunanoordin do a review. |
261e5d6
to
94aa439
Compare
All unit tests are passing. ✅ |
- swap `project.links.workflows` for `project.links.active_workflows` when validating workflow IDs in `app-project`. - add a `useProjectRoles` hook to the classifier, which gets roles for a project, user and token. - check project roles during workflow selection. Allow owners, testers and collaborators to select any project workflow. - add a usePanoptesUser hook. - add a usePanoptesAuth hook. - move `useStores` to the hooks directory.
94aa439
to
9d9cb4a
Compare
I've opened #2993 to add some simple routing to the dev classifier, using |
PR #2993 looks good and is approved. With this update, I believe this PR is good to go. |
project.links.workflows
forproject.links.active_workflows
when validating workflow IDs inapp-project
.usePanoptesAuth
,usePanoptesUser
anduseProjectRoles
hooks to the classifier.useStores
into thehooks
directory.To test this PR, add an inactive workflow to a project, in the project builder, then load that workflow directly by ID in either the dev classifier or the project app. It should load, if you are logged in as a user that has permission to view all project workflows. If not, you should see the usual error in the browser console:
unable to load workflow X for project Y.
Package:
app-project
lib-classifier
Review Checklist
General
Components
Apps
yarn panic && yarn bootstrap
ordocker-compose up --build
and app works as expected?Publishing
Post-merging