Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loading
state to the classifier container. Defer rendering theClassifier
until after the container is mounted and the store has initialised.#2863 re-opened #2954 on staging, because the classifier store now loads synchronously (
loading
inClassifierContainer
is never false.) This PR should fix that by deferring the first render of theClassifier
until after the classifier store is initialised (and the classifier UPP store has been reset.) To test it out, load the classifier while logged out, then log in on the Classify page of a project so that you are signing in to an existing classifier store (with UPP loading state already set.)Package:
lib-classifier
Closes #2954.
Review Checklist
General
Components
Apps
yarn panic && yarn bootstrap
ordocker-compose up --build
and app works as expected?Publishing
Post-merging