[Security] Remove markdown-it-html5-embed #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
html5-media
branch
4 times, most recently
from
198182f to
f77539b
Compare
- Add tests for images with audio and video URLs. - Remove `markdown-it-html5-embed`, which is quite old, depends on an outdated version of `markdown-it`, and loads in all of `mime-db` to check for audio or video URLs. - Replace it with `lib/html5-embed`, a modified version of the original plugin, updated to use `mime/lite` to lookup MIME types for audio and video, in the browser. - Bump `jsdom`, `isomorphic-dompurify` and outdated `@babel` packages.
eatyourgreens
force-pushed
the
html5-media
branch
from
f77539b to
2fc4288
Compare
mcbouslog
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markdown-it-html5-embed, which is quite old, depends on an outdated version ofmarkdown-it, and loads in all ofmime-dbto check for audio or video URLs.lib/html5-embed, a modified version of the original plugin, updated to usemime/liteto lookup MIME types for audio and video in the browser.jsdom,isomorphic-dompurify, and@babelpackages.