House keeping

[Alextopher]

• Runs cargo fmt
• Addresses all existing cargo clippy lints
• Adds CI to verify cargo fmt and cargo clippy

There were a lot of lints in tests - to make my life easier I removed a lot of boilerplate.

Better late than never 😄

[Alextopher]

looks like this might interfere with #115

[Alextopher]

@zslayton #112 #115 #116 all look like quality bug fixes.

I think it would be best if those were merged first then I will rebase this PR.

[zslayton]

Two of these have been merged, #115 (the most substantive change) is still pending. #123 addressed the current clippy and rustfmt issues, but did not add those steps to the CI. If you're interested in adding the CI steps as a fresh PR, that might be the quickest path forward.

[bombsimon]

Oops, sorry I missed that this PR included the same fixes for fmt and clippy as I made in #123, sorry about that! But I didn't add any CI checks (which I should've) so this PR and changes still looks like a good one to merge!

[Alextopher]

I'll try to rebase this today!

[LeoniePhiline]

@Alextopher #129 just got merged. In case you are currently working on the rebase, I hope this message reaches you before another rebase causes you extra work.

[LeoniePhiline]

How about adding the following clippy linting configuration to Cargo.toml:

[lints.clippy]
pedantic = { level = "warn", priority = -1 }
perf = { level = "warn", priority = -1 }
cargo = { level = "warn", priority = -1 }

I also like to use these code quality compiler lints in my own projects:

[lints.rust]
elided_lifetimes_in_paths = "warn"
future_incompatible = { level = "warn", priority = -1 }
let_underscore = { level = "warn", priority = -1 }
missing_copy_implementations = "warn"
missing_debug_implementations = "warn"
missing_docs = "warn"
# must_not_suspend = "warn" # Unstable - tracked at https://github.com/rust-lang/rust/issues/83310
non_ascii_idents = "warn"
nonstandard_style = { level = "warn", priority = -1 }
noop_method_call = "warn"
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage)'] }
unnameable_types = "warn"
unreachable_pub = "warn"
unused = { level = "warn", priority = -1 }
unused_crate_dependencies = "warn"
unused_lifetimes = "warn"

# lossy_provenance_casts = "deny" # Unstable - tracked at https://github.com/rust-lang/rust/issues/95228
# fuzzy_provenance_casts = "deny" # Unstable - tracked at https://github.com/rust-lang/rust/issues/95228
unsafe_code = "deny" # Exceptions must be discussed and deemed indispensable and use `#![deny(invalid_reference_casting, unsafe_op_in_unsafe_fn)]`.

[Alextopher]

Hi everyone, I looked into it and it doesn't seem like there's much more in this PR that is worth merging. A new PR is probably better, as for now I think I should close this PR and leave it an open project for someone else. Thanks!