House keeping #117
House keeping #117
Conversation
| .and_hms_opt(hour, minute, second) | ||
| // .ymd(year as i32, month, day_of_month) | ||
| // .and_hms_opt(hour, minute, second) | ||
| .with_ymd_and_hms( |
There was a problem hiding this comment.
looks like this might interfere with #115
There was a problem hiding this comment.
There was a problem hiding this comment.
Oops, sorry I missed that this PR included the same fixes for fmt and clippy as I made in #123, sorry about that! But I didn't add any CI checks (which I should've) so this PR and changes still looks like a good one to merge!
There was a problem hiding this comment.
I'll try to rebase this today!
There was a problem hiding this comment.
@Alextopher #129 just got merged. In case you are currently working on the rebase, I hope this message reaches you before another rebase causes you extra work.
|
How about adding the following clippy linting configuration to [lints.clippy]
pedantic = { level = "warn", priority = -1 }
perf = { level = "warn", priority = -1 }
cargo = { level = "warn", priority = -1 }I also like to use these code quality compiler lints in my own projects: [lints.rust]
elided_lifetimes_in_paths = "warn"
future_incompatible = { level = "warn", priority = -1 }
let_underscore = { level = "warn", priority = -1 }
missing_copy_implementations = "warn"
missing_debug_implementations = "warn"
missing_docs = "warn"
# must_not_suspend = "warn" # Unstable - tracked at https://github.com/rust-lang/rust/issues/83310
non_ascii_idents = "warn"
nonstandard_style = { level = "warn", priority = -1 }
noop_method_call = "warn"
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage)'] }
unnameable_types = "warn"
unreachable_pub = "warn"
unused = { level = "warn", priority = -1 }
unused_crate_dependencies = "warn"
unused_lifetimes = "warn"
# lossy_provenance_casts = "deny" # Unstable - tracked at https://github.com/rust-lang/rust/issues/95228
# fuzzy_provenance_casts = "deny" # Unstable - tracked at https://github.com/rust-lang/rust/issues/95228
unsafe_code = "deny" # Exceptions must be discussed and deemed indispensable and use `#![deny(invalid_reference_casting, unsafe_op_in_unsafe_fn)]`.
|
|
Hi everyone, I looked into it and it doesn't seem like there's much more in this PR that is worth merging. A new PR is probably better, as for now I think I should close this PR and leave it an open project for someone else. Thanks! |
Followup from zslayton#117 and partly zslayton#123 addressing these issues. This is now checked in the GitHub action pipeline to avoid adding new violations.
* chore: Add `cargo fmt` and `clippy` checks to GitHub action Followup from #117 and partly #123 addressing these issues. This is now checked in the GitHub action pipeline to avoid adding new violations. * chore: Update `actions/checkout` * fix: Fix `clippy` issues Remove lifetime annotations which can rely on lifetime elision.
cargo fmtcargo clippylintscargo fmtandcargo clippyThere were a lot of lints in
tests- to make my life easier I removed a lot of boilerplate.Better late than never 😄