chore: Add cargo fmt and clippy checks to GitHub action
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup from zslayton#117 and partly zslayton#123 addressing these issues. This is now checked in the GitHub action pipeline to avoid adding new violations.
Remove lifetime annotations which can rely on lifetime elision.
|
How ironic I was running an old version and didn't spot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from House keeping #117 and partly Run
cargo fmtand fix allclippyreports #123 addressing these issues. This is nowchecked in the GitHub action pipeline to avoid adding new violations.
clippyissuesRemove lifetime annotations which can rely on lifetime elision.
I did not add any suggestions from #117 (comment), it feels a bit too opinionated and didn't include any explanations or reasoning. Instead I opted to use the default settings for linting.