-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomizer v1.2 #34
Merged
Merged
Randomizer v1.2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to contain current ER work.
…matic to seed-based.
- Updated version to 1.2 - Updated skipper code to be more optimized - Added ER code just as a framework.
…n item wheel close
- Added fourth mirror shard item - Added function definitions for shop functions - Added function definitions for custom signs
- Created a framework to give items to the player when they are not doing anything. - Applied a patch to the master sword actor that adds two checks to the game. - Added code that gives the player a check when they have defeated Stallord - Updated various code to reflect fleshed out libtp definitions
- modified it so save warping in N Faron spawns you in central area.
… to support simplified format
Pushing current 1.2 changes to zsrtp repo
This is to prevent game crashes if a seed is not loaded.
Various adjustments
- Changed the custom event item process to be a queue based system instead of a true/false. The old system assumed that the next event is always a get-item event, which is not always true. - removed the calls to verifyProgressiveItem before adding an item to the event queue because when giving an item, the event system calls createItemForPresentDemo, which also calls verifyProgressiveItem.
…djusted spawn for FW sign as well
The flag is now set when 20 poe souls have actually been collected, via the _00_handle_poeItem function.
This causes defeated Poes (excluding Arbiter Poes) to immediately despawn, and the item they would give is added to the queue to give to the player when they are free. Also adjusted _00_handle_poeItem to not increment the Poe count if it is already at 60 or greater. Also increased the amount of bytes used for queued items to 8.
Fix being able to lose Poe items
This reverts commit 6bd200e.
This is necessary because the player potentially could have died after initializing getting an item (which would set giveItemToPlayer to ITEM_IN_QUEUE), and then chosen to return to the title screen.
Reset giveItemToPlayer upon starting/loading a file
Adjust killing poes to skip the backflip and trigger the item get imm…
This is because the reserved bytes that the queue uses to store the items to give are not cleared upon starting a new file, which means that the player could soft reset during the process of being given item(s), and then start a new file to be given those items on that new file. Also moved resetting giveItemToPlayer to QUEUE_EMPTY to resetQueueOnFileSelectScreen as well, since it makes more sense for it to be reset there alongside the reserved bytes being cleared.
Clear reserved bytes upon reaching title screen
Merge 1.2 dev changes to main dev
Zephiles
approved these changes
Aug 2, 2024
kipcode66
pushed a commit
to kipcode66/Randomizer
that referenced
this pull request
Sep 2, 2024
add devcontainer configs + elf2rel update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.