-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add config file for Nice IBT4 BusT4 #2525
Conversation
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These alarm configurations need to be partial parameters
@AlCalzone I may need a hand with this one. Maybe just some pointers would be great on partials. I have started here focused around slot one since they are a clone. https://github.com/cdnninja/node-zwave-js/blob/master/packages/config/config/devices/0x0441/ibt4zwave.json
|
As you suspected, your bitmasks are wrong.
Looking at the manual
the high byte (3) is the Notification type, byte (2) the status and (1) the notification event. Byte 0 is the "action" of the device itself In the documentation for partial params, we have a bitmask calculator to help you figure out the bitmask. Here's what it spits out for the notification type byte:
Notification status has possible values 0 and 255. Since 255 means "Unsolicited transmissions are enabled for the specified Notification Type", I'm not even sure if allowing 0 makes sense. |
Actually, reading the manual confuses me more. They call the bytes Notification Type, Notification Status, and Event/State Parameters, but the explanations next to the values treat Notification Status as if it were the Notification Event...
So maybe byte 2 is actually the notification event (0-255) and byte 1 a single-byte event parameter (0-255). |
@AlCalzone @cdnninja Can I help in some way? If you want me to test something let me know. |
Sorry, but that info has nothing to do with the configuration parameters that influence which notification events are sent. |
@AlCalzone I have updated with your feedback. I left 0 as available for notification status as the manual states 0 is the default of disabled for a few of the slots. If the first slot looks good I will clone this to the others reflecting defaults and such. I think we start with following the documentation and see if it works as intended. |
#2576 2576 |
#2576) Co-authored-by: AlCalzone <d.griesel@gmx.net>
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
1 similar comment
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
@zwave-js-bot fix lint |
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
🐌 Please wait for the lint check to complete, then try again. |
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
@zwave-js-bot fix lint |
fixes: #2518
TODO: