Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runtime shaving #526

Merged
merged 33 commits into from
May 6, 2022
Merged

Test runtime shaving #526

merged 33 commits into from
May 6, 2022

Conversation

zivkovicmilos
Copy link
Contributor

Description

This PR cuts down on the test runtime significantly.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Additional comments

Fixes EDGE-383

zivkovicmilos and others added 23 commits April 24, 2022 21:57
@zivkovicmilos
Cut down on TestNewFilter_Logs
ac46663
@zivkovicmilos
Cut down on TestFilterValue
8487d9d
@zivkovicmilos
Cut down on TestGenesisCustomBlockGasLimit
154292c
@dbrajovic
remove obsolete encoding test
fead7d3
@dbrajovic
Merge branch 'feature/test-shaving' of https://github.com/0xPolygon/p…
d7547e6 
…olygon-edge into feature/test-shaving
@dbrajovic
reduce TestIbft_Transfer duration
aaccfe2
@zivkovicmilos
Remove useless TestCustomBlockGasLimitPropagation
d030363
@zivkovicmilos
Cut down on TestIbft_TransactionFeeRecipient
76f5ce6
@zivkovicmilos
Remove 1M test case from TestAddTxns
481b21d
@dbrajovic
remove double test TestSignedTransaction; same as TestIbftTransfer
ea349ec
@dbrajovic
Merge branch 'feature/test-shaving' of https://github.com/0xPolygon/p…
5e5a446 
…olygon-edge into feature/test-shaving
@zivkovicmilos
Remove useless Dev stress test
91ad484
@dbrajovic
remove obsolete test: TestTxPool_ErrorCodes (tested by TestAddTxErrors)
12d7037
@dbrajovic
run tests in parallel (TestAddTxErrors)
e6081c6
@dbrajovic
Merge branch 'feature/test-shaving' of https://github.com/0xPolygon/p…
c3ec677 
…olygon-edge into feature/test-shaving
@dbrajovic
call t.Parallel on top level (go spec)
d67effb
@zivkovicmilos
Parallelize tests
3d4073d
@dbrajovic
remove TestTxPool_TransactionCoalescing; tested in TestPromoteHandler
9a651e4
@dbrajovic
Merge branch 'feature/test-shaving' of https://github.com/0xPolygon/p…
2530949 
…olygon-edge into feature/test-shaving
@dbrajovic
parallelize TestPromoteHandler
3643314
@zivkovicmilos
Add further paralelization
2056ee6
@zivkovicmilos
Resolve linting errors
cd10b4f
@zivkovicmilos
Remove double parallel
e183997
@zivkovicmilos zivkovicmilos added the feature New update to Polygon Edge label Apr 27, 2022
@zivkovicmilos zivkovicmilos mentioned this pull request Apr 28, 2022
Merged
11 tasks
@Kourin1996
Optimize TestBroadcast e2e test (#527)
e87dc06 
* Optimize TestBroadcast

* Add AtomicErrors in e2e framework

* Fix lint error

* Change sync.Mutex to RWMutex in AtomicErrors
@zivkovicmilos zivkovicmilos marked this pull request as ready for review April 28, 2022 13:45
@zivkovicmilos
Update GH actions script (#531)
36ecb01 
* Remove recursive submodule fetch from lint action

* Swap out the checkout version to v3

* Upgrade go setup action

* Remove useless go race build

* Add OS matrix strategy

* Remove matrix execution, as it offers little value for now

* Remove the verbose flag

* Bring back race builds
@zivkovicmilos
Fix go parallel loop bug
eac3648
@zivkovicmilos
Merge branch 'develop' into feature/test-shaving
293c8ef
0xAleksaOpacic
0xAleksaOpacic approved these changes May 6, 2022
View reviewed changes
archive/backup_test.go Show resolved Hide resolved
jsonrpc/eth_state_test.go Show resolved Hide resolved
@0xAleksaOpacic
Copy link
Contributor

Can we remove this test and if needed add linear card for it

polygon-edge/txpool/txpool_test.go

Line 1060 in 293c8ef

func TestDemote(t *testing.T) {

@0xAleksaOpacic
Copy link
Contributor

0xAleksaOpacic commented May 6, 2022 •
edited
Loading

When i have started tests locally i am getting the error. Tried it 2 times, can you please check this
--- FAIL: TestState (0.00s)
state_test.go:122: open tests/GeneralStateTests: no such file or directory
--- FAIL: TestEVM (0.00s)
evm_test.go:146: open tests/VMTests: no such file or directory
FAIL

@zivkovicmilos
Copy link
Contributor Author

When i have started tests locally i am getting the error. Tried it 2 times, can you please check this --- FAIL: TestState (0.00s) state_test.go:122: open tests/GeneralStateTests: no such file or directory --- FAIL: TestEVM (0.00s) evm_test.go:146: open tests/VMTests: no such file or directory FAIL

@Aleksao998

Did you pull in the submodules?
git submodule update --init --recursive from the base of the repo

@zivkovicmilos
Copy link
Contributor Author

@Aleksao998

Removed the unused TestDemote:

3cd2919

cc @dbrajovic

ZeljkoBenovic
ZeljkoBenovic approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job guys 🏅

I'm slapping this Approve so hard...

@zivkovicmilos zivkovicmilos merged commit 61e5829 into develop May 6, 2022
@zivkovicmilos zivkovicmilos deleted the feature/test-shaving branch May 6, 2022 13:05
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0xAleksaOpacic 0xAleksaOpacic 0xAleksaOpacic approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@ZeljkoBenovic ZeljkoBenovic ZeljkoBenovic approved these changes

@lazartravica lazartravica Awaiting requested review from lazartravica

Assignees

@zivkovicmilos zivkovicmilos

@Kourin1996 Kourin1996

@dbrajovic dbrajovic

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zivkovicmilos @0xAleksaOpacic @Kourin1996 @ZeljkoBenovic @dbrajovic