Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #77

Merged
merged 5 commits into from
Dec 8, 2023
Merged

develop #77

merged 5 commits into from
Dec 8, 2023

Conversation

adam-buckley
Copy link
Contributor

@adam-buckley adam-buckley commented Dec 8, 2023

Checklist

  • I'm using the correct PHP Version (8.1 for current, 7.4 for legacy).
  • I've added comments to any new methods I've created or where else relevant.
  • I've replaced magic method usage on DbService classes with the getInstance() static method.
  • I've written any documentation for new features or where else relevant in the docs repo.

Description

Changelog

refs:
issues:

Other Information

Docs pull request:

DerekCrannaford and others added 5 commits May 2, 2023 10:15
* First cut working, some kludges

* First cut regressions for use

* DB config for local

* Incremental regressions into CodeSpaces

* Correct testrunner config

* No subsystem

* Abandon auto chmod

* As running in space

* Check remote can push

* GitIgnore UnitTest cache

* Check can push from remote

* Check can push from remote

* Try to fix xdebug

* Tentative XDebug OK

* Retested Xdebug setup

* Try DBug without restart

* Still tweaking XDB

* Still nudging XDB

* Still A/B testing XDB settings

* Update CI SeleniumRefs & Lint Docker Compose

* Radically simplify XDebug ini

* smtp config in template

* Additional test env config on mail

* Refactor per 8.1 ambitions

* Skip questionable linter compatibility

* Try alternative linter

* Try 8.1 version overtrue

* Use checkout v3

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
* Feature: work to codeception5 (#66) (#68)

* First cut working, some kludges

* First cut regressions for use

* DB config for local

* Incremental regressions into CodeSpaces

* Correct testrunner config

* No subsystem

* Abandon auto chmod

* As running in space

* Check remote can push

* GitIgnore UnitTest cache

* Check can push from remote

* Check can push from remote

* Try to fix xdebug

* Tentative XDebug OK

* Retested Xdebug setup

* Try DBug without restart

* Still tweaking XDB

* Still nudging XDB

* Still A/B testing XDB settings

* Update CI SeleniumRefs & Lint Docker Compose

* Radically simplify XDebug ini

* smtp config in template

* Additional test env config on mail

* Refactor per 8.1 ambitions

* Skip questionable linter compatibility

* Try alternative linter

* Try 8.1 version overtrue

* Use checkout v3

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>

* Stop core default as MASTER when no PHPversion

---------

Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
* Feature: work to codeception5 (#66) (#68)

* First cut working, some kludges

* First cut regressions for use

* DB config for local

* Incremental regressions into CodeSpaces

* Correct testrunner config

* No subsystem

* Abandon auto chmod

* As running in space

* Check remote can push

* GitIgnore UnitTest cache

* Check can push from remote

* Check can push from remote

* Try to fix xdebug

* Tentative XDebug OK

* Retested Xdebug setup

* Try DBug without restart

* Still tweaking XDB

* Still nudging XDB

* Still A/B testing XDB settings

* Update CI SeleniumRefs & Lint Docker Compose

* Radically simplify XDebug ini

* smtp config in template

* Additional test env config on mail

* Refactor per 8.1 ambitions

* Skip questionable linter compatibility

* Try alternative linter

* Try 8.1 version overtrue

* Use checkout v3

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>

* Stop core default as MASTER when no PHPversion (#69)

---------

Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
* Feature: work to codeception5 (#66) (#68)

* First cut working, some kludges

* First cut regressions for use

* DB config for local

* Incremental regressions into CodeSpaces

* Correct testrunner config

* No subsystem

* Abandon auto chmod

* As running in space

* Check remote can push

* GitIgnore UnitTest cache

* Check can push from remote

* Check can push from remote

* Try to fix xdebug

* Tentative XDebug OK

* Retested Xdebug setup

* Try DBug without restart

* Still tweaking XDB

* Still nudging XDB

* Still A/B testing XDB settings

* Update CI SeleniumRefs & Lint Docker Compose

* Radically simplify XDebug ini

* smtp config in template

* Additional test env config on mail

* Refactor per 8.1 ambitions

* Skip questionable linter compatibility

* Try alternative linter

* Try 8.1 version overtrue

* Use checkout v3

---------

Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>

* Stop core default as MASTER when no PHPversion (#69)

* Allow test nav helper to be re-entrant

---------

Co-authored-by: Adam Buckley <adam.buckley90@gmail.com>
Co-authored-by: Derek Crannaford <derek@2pisoftware.com>
@adam-buckley adam-buckley marked this pull request as ready for review December 8, 2023 00:17
@adam-buckley adam-buckley self-assigned this Dec 8, 2023
dragonflyfree

This comment was marked as duplicate.

Copy link
Contributor

@dragonflyfree dragonflyfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes (thumbs up emoji)

@adam-buckley adam-buckley merged commit 2f2c746 into master Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants