Fix channel mentions and add option to disable channel mentions as IR…

…C NOTICEs (mattermost) (#418)

* Allow overriding default channel wide mentions as IRC NOTICEs (#416)

* Fixed so only original message with channel wide mentions are IRC NOTICEs (#416)

bridge/mattermost/mattermost.go

@@ -735,6 +735,7 @@ func (m *Mattermost) handleWsActionPost(rmsg *model.WebSocketEvent) {
 		return
 	}
 
+	replyMessage := ""
 	if data.ParentId != "" {
 		parentPost, resp := m.mc.Client.GetPost(data.ParentId, "")
 		if resp.Error != nil {
@@ -744,7 +745,7 @@ func (m *Mattermost) handleWsActionPost(rmsg *model.WebSocketEvent) {
 
 			if !m.v.GetBool("mattermost.hidereplies") {
 				parentMessage := maybeShorten(parentPost.Message, m.v.GetInt("mattermost.ShortenRepliesTo"), "@", m.v.GetBool("mattermost.unicode"))
-				data.Message = fmt.Sprintf("%s (re @%s: %s)", data.Message, parentGhost.Nick, parentMessage)
+				replyMessage = fmt.Sprintf(" (re @%s: %s)", parentGhost.Nick, parentMessage)
 			}
 		}
 	}
@@ -809,7 +810,7 @@ func (m *Mattermost) handleWsActionPost(rmsg *model.WebSocketEvent) {
 		return
 	}
 
-	msgs := strings.Split(data.Message, "\n")
+	msgs := strings.Split(data.Message+replyMessage, "\n")
 
 	channelType := ""
 	if t, ok := props["channel_type"].(string); ok {
@@ -886,13 +887,18 @@ func (m *Mattermost) handleWsActionPost(rmsg *model.WebSocketEvent) {
 			}
 		case strings.Contains(data.Message, "@channel") || strings.Contains(data.Message, "@here") ||
 			strings.Contains(data.Message, "@all"):
+
+			messageType := "notice"
+			if m.v.GetBool("mattermost.disabledefaultmentions") {
+				messageType = ""
+			}
 			event := &bridge.Event{
 				Type: "channel_message",
 				Data: &bridge.ChannelMessageEvent{
 					Text:        msg,
 					ChannelID:   data.ChannelId,
 					Sender:      ghost,
-					MessageType: "notice",
+					MessageType: messageType,
 					ChannelType: channelType,
 					Files:       m.getFilesFromData(data),
 					MessageID:   data.Id,

matterircd.toml.example

@@ -135,6 +135,9 @@ SuffixContext = false
 #This will show (mention yournick) after a message if it contains one of the words configured
 #in your mattermost "word that trigger mentions" notifications.
 ShowMentions = false
+# Channel wide default mentions @channel, @all, and @here are shown as IRC NOTICEs.
+# This disables that making them appear as normal PRIVMSGs.
+#DisableDefaultMentions = true
 
 # Path to file to store last viewed information. This is useful for replying only
 # the messages missed.