Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@here messages and threads are NOTICEs and not PRIVMSGs #416

Closed
axinojolais opened this issue Mar 12, 2021 · 6 comments · Fixed by #418
Closed

@here messages and threads are NOTICEs and not PRIVMSGs #416

axinojolais opened this issue Mar 12, 2021 · 6 comments · Fixed by #418

Comments

@axinojolais
Copy link

Hi,

It would appear that whenever someone uses @here, the message and every message in the same thread are sent as NOTICEs and not PRIVMSGs. Any reason for that ? Can we make them PRIVMSGs ? I see no reason to send them as NOTICEs but I may be missing something.

Thanks !

@hloeung
Copy link
Collaborator

hloeung commented Mar 13, 2021

IMO, it should remain as NOTICEs. It's sort of like any other Mattermost client where @here, @channel, and @ALL are like broadcasts causing highlighting for those users online at the time.

@42wim
Copy link
Owner

42wim commented Mar 13, 2021

I agree with @hloeung

@axinojolais
Copy link
Author

Do other mattermost clients highlight everyone for all messages in a thread where @here was used ?
Also, my IRC client (irssi), neither @here nor NOTICEs highlight by default, which seems reasonable.

If you look at RFC1459, NOTICEs are used to avoid automatic replies, not to highlight people. And I don't think whole threads should highlight everyone or appear differently in my client because someone used @here.

@hloeung
Copy link
Collaborator

hloeung commented Mar 15, 2021

Do other mattermost clients highlight everyone for all messages in a thread where @here was used ?
Also, my IRC client (irssi), neither @here nor NOTICEs highlight by default, which seems reasonable.

Yeah, from https://docs.mattermost.com/help/settings/channel-settings.html#ignore-mentions-for-channel-here-and-all

By default, you will recieve mention notifications for any uses of @channel, @all or @here in a channel...

How about an option to disable this behavior? #418

hloeung added a commit to hloeung/matterircd that referenced this issue Mar 15, 2021
hloeung added a commit to hloeung/matterircd that referenced this issue Mar 15, 2021
@axinojolais
Copy link
Author

Do other mattermost clients highlight everyone for all messages in a thread where @here was used ?
Also, my IRC client (irssi), neither @here nor NOTICEs highlight by default, which seems reasonable.

Yeah, from https://docs.mattermost.com/help/settings/channel-settings.html#ignore-mentions-for-channel-here-and-all

By default, you will recieve mention notifications for any uses of @channel, @all or @here in a channel...

This only talks about messages with @here, not all messages in a thread where a single message has @here.

How about an option to disable this behavior? #418

That would make indeed resolve this bug for me :)

@hloeung
Copy link
Collaborator

hloeung commented Mar 15, 2021

This only talks about messages with @here, not all messages in a thread where a single message has @here.

Oh! Understand now. So it's actually because the parent message has the channel wide mentions @{here,channel,all) and that gets included in the bit that checks if it should be a NOTICE or not. hloeung@a75d1b6 specifically fixes this so it's only whichever message that has @{here,channel,all}.

e.g.

|21:37 -hloeung:#haw-test- @here Testing again [@@4f7tqoranpgd9bb98itfxt87qw]
|21:37 <hloeung> This time replying, which shouldn't be an IRC NOTICE message but rather PRIVMSG (re @hloeung: @here Testing again) [↪@@4f7tqoranpgd9bb98itfxt87qw]

hloeung added a commit to hloeung/matterircd that referenced this issue Mar 15, 2021
42wim pushed a commit that referenced this issue Mar 19, 2021
…C NOTICEs (mattermost) (#418)

* Allow overriding default channel wide mentions as IRC NOTICEs (#416)

* Fixed so only original message with channel wide mentions are IRC NOTICEs (#416)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants