Fix channel mentions and add option to disable channel mentions as IRC NOTICEs #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
channel-mentions
branch
from
e752e14
to
8ae291e
Compare
hloeung
changed the title
hloeung
force-pushed
the
channel-mentions
branch
2 times, most recently
from
c3c51fc
to
a75d1b6
Compare
hloeung
force-pushed
the
channel-mentions
branch
from
a75d1b6
to
98eab24
Compare
hloeung
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
We fix it so only if the message contains channel mentions @{here,channel,all} rather than if the parent message:
Also adds an option to allow disabling channel wide mentions. When enabled:
When disabled, which is the current behavior: