Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tool to load and unload gltf files from the MainScene.unity #22

Merged
merged 29 commits into from
May 28, 2024

Conversation

Etiennefaivredarcier
Copy link
Contributor

To simplify the testing of the glTF files, we have been working on implementing a very simple system to load and unload glTF at runtime without the need to reload application. This has been especially useful to test on Android devices

@nlsdvl nlsdvl added this to the Version 1.0.0 milestone Mar 15, 2024
@nlsdvl nlsdvl added the enhancement New feature or request label Mar 15, 2024
Packages/manifest.json Outdated Show resolved Hide resolved
Packages/manifest.json Outdated Show resolved Hide resolved
@@ -12,6 +12,16 @@
"com.unity.burst": "1.6.6"
}
},
"com.google.ar.core.arfoundation.extensions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Etiennefaivredarcier this package is not available through UPM. It can be added as an embedded dependency. Here's how I did it on my side, assuming we want v1.41.0 :

cd Packages
git submodule add https://github.com/google-ar/arcore-unity-extensions.git com.google.ar.core.arfoundation.extensions
cd com.google.ar.core.arfoundation.extensions
git checkout v1.41.0

ProjectSettings/EditorBuildSettings.asset Outdated Show resolved Hide resolved
Assets/Scripts/Runtime/SceneViewer.cs Outdated Show resolved Hide resolved
Assets/Scripts/Runtime/SceneViewer.cs Outdated Show resolved Hide resolved
Assets/Scripts/Runtime/SceneViewer.cs Outdated Show resolved Hide resolved
Assets/Scripts/Runtime/SceneViewer.cs Outdated Show resolved Hide resolved
@nlsdvl nlsdvl self-requested a review April 26, 2024 09:58
{
m_Txt.text = _property.name;
#if UNITY_ANDROID && !UNITY_EDITOR
m_Path = Application.persistentDataPath + "/" + _property.path;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks loading data over http.

@nlsdvl nlsdvl self-requested a review April 26, 2024 11:43
@nlsdvl nlsdvl merged commit 00ca06e into development May 28, 2024
7 checks passed
@nlsdvl nlsdvl deleted the feature/interactivity branch May 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
2 participants