Squashed commit of the following:

commit 5047b26 Author: Prajwal Borkar <48290911+PrajwalBorkar@users.noreply.github.com> Date: Tue May 17 19:14:53 2022 +0530 Updated get_cams protocol to https pvlib#1457 (pvlib#1458) * Updated get_cams protocol to https pvlib#1457 * Updated instances of http to https. pvlib#1457 * Updated documentation links to https * Added Contributor commit a0812b1 Author: roger-lcc <58332996+roger-lcc@users.noreply.github.com> Date: Wed May 4 20:01:42 2022 +0800 CI asv check (pvlib#1454) * CI asv check * added CI asv check * CI asv check * CI asv check * updated CI asv check * Update docs/sphinx/source/whatsnew/v0.9.2.rst updated v0.9.2.rst Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> commit 83e379a Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Thu Apr 28 19:26:09 2022 -0400 Bump pandas to 0.25.0; test updates (pvlib#1448) * bump pandas min from 0.22.0 to 0.25.0 * fix buggy test__check_pandas_assert_kwargs don't use monkeypatch and mocker in the same test function. pytest-dev/pytest-mock#289 * fix psm3 test (apparent_zenith -> solar_zenith) * whatsnew * better UTC conversion in sun_rise_set_transit_ephem * helpful comments * more whatsnew * '3.0' -> '3' in read_crn test? * apply dtypes during parsing in read_crn * move dropna() post-processing into read_fwf call * fix read_crn for pandas<1.2.0 * Update pvlib/solarposition.py Co-authored-by: Will Holmgren <william.holmgren@gmail.com> * nix pytz * UTC -> utc * address simd arccos issue in tracking.singleaxis Co-authored-by: Will Holmgren <william.holmgren@gmail.com> commit 8d0f863 Author: Naman Priyadarshi <77211855+Naman-Priyadarshi@users.noreply.github.com> Date: Tue Apr 12 22:55:58 2022 +0530 Advance numba from 0.36.1 to 0.40.0 in asv py3.6 environment (pvlib#1440) * Advance numba from 0.36.1 to 0.40.0 * Advance numba from 0.36.1 to 0.40.0 * Updated whatsnew.rst commit 5cb695d Author: Naman Priyadarshi <77211855+Naman-Priyadarshi@users.noreply.github.com> Date: Wed Apr 6 23:58:03 2022 +0530 Remove unnecessary **kwargs from spa_python and get_total_irradiance (pvlib#1437) * Update Solarposition.py Removed **kwargs from pvlib.solarposition.spa_python * Added v0.9.2.rst, changes in pvlib/irradiance.py and pvlib/location.py Made new v0.9.2.rst and removed **kwargs from pvlib/irradiance.py (Line 309) and pvlib/location.py (Line 234-235) * Update docs/sphinx/source/whatsnew/v0.9.2.rst * Update docs/sphinx/source/whatsnew/v0.9.2.rst Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> commit 8460b36 Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Tue Mar 29 15:31:25 2022 -0600 Finalize 0.9.1 (pvlib#1431) * fix heading levels in user_guide/bifacial.rst * whatsnew cleanup * fix readme html missing tag, maybe unicode zero-width spaces? * readme: link to universal zenodo doi * readme: update installation link for pvlib#1173 * whatsnew date * additional contributors * delete errant space commit edbf2a6 Author: RoyCoding8 <92641125+RoyCoding8@users.noreply.github.com> Date: Wed Mar 30 01:58:18 2022 +0530 Updated plot_singlediode.py (pvlib#1434) * Update plot_singlediode.py Changed the unit from C to degree C (°C) * Update plot_singlediode.py Changed to LaTeX \degree symbol in matplotlib which avoids any encoding issues with using Unicode characters. * Update v0.9.1.rst Added name to the contributors' list * Update v0.9.1.rst commit cf4a8ad Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Tue Mar 29 14:04:40 2022 -0600 Update sphinx to 4.5.0 (pvlib#1435) * bump sphinx and pydata-sphinx-theme versions * clean up sphinx conf.py * fix distutils strangeness, maybe * use freshly-released sphinx==4.5.0 commit 884a153 Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Wed Mar 23 13:41:35 2022 -0600 Clarify delta_t docstring descriptions (pvlib#1429) * clarify delta_t docstrings * whatsnew commit c243183 Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Thu Mar 17 12:01:57 2022 -0600 Deprecate pvlib.forecast (pvlib#1426) * deprecate pvlib.forecast classes * catch warnings in tests * add warning admonition to forecasts.rst * whatsnew * stickler * pin pytest < 7.1.0 * pin pytest in the right place this time * more warning suppression in tests * unpin pytest * Update docs/sphinx/source/whatsnew/v0.9.1.rst * copy warning to reference/forecasting.rst commit e3baa12 Author: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> Date: Thu Mar 17 11:28:56 2022 -0600 Fix conditional dependency on dataclasses (pvlib#1422) * better conditional dependency on dataclasses * whatsnew commit 27cba7a Author: Naman Priyadarshi <77211855+Naman-Priyadarshi@users.noreply.github.com> Date: Thu Mar 17 22:48:08 2022 +0530 Added asv benchmarking badge to the table of badges in the main README. (pvlib#1427) * Update Readme.md Added benchmarks asv badge to the badge section * Updated v.0.9.1.rst Added my name to the list of Contributers. commit 1893b20 Author: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> Date: Mon Mar 14 18:37:58 2022 +0100 Add variable mapping of psm3 (pvlib#1374) * Add variable mapping of psm3 * Add enhancement entry in whatsnew * Fix stickler * Map keys in metadata dict * Remove double spaces in docs * Fix stickler * Doc update Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> * Reformatting - changes by kanderso-nrel * Update docstring table with 2020 * Add deprecation warning test coverage * Rename to VARIABLE_MAP * Change apparent_zenith to solar_zenith Based on the decision in pvlib#1403 * Update attributes docstring * Change elevation to altitude when mapping variables * Update psm3 variable mapping test Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
AdamRJensen · May 19, 2022 · b313c64 · b313c64
1 parent fa8b9e4
commit b313c64
Show file tree

Hide file tree

Showing 30 changed files with 372 additions and 124 deletions.
diff --git a/.github/workflows/asv_check.yml b/.github/workflows/asv_check.yml
@@ -0,0 +1,34 @@
+name: asv
+
+# CI ASV CHECK is aimed to verify that the benchmarks execute without error.
+on: [pull_request, push]
+
+jobs:
+  quick:
+    runs-on: ubuntu-latest
+    defaults: 
+      run:
+        shell: bash -el {0}
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+
+      - name: Install Python
+        uses: actions/setup-python@v3
+        with:
+          python-version: '3.9.7'
+
+      - name: Install asv
+        run: pip install asv==0.4.2
+
+      - name: Run asv benchmarks
+        run: |
+          cd benchmarks
+          asv machine --yes
+          asv run HEAD^! --quick --dry-run --show-stderr | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
+          if grep "failed" benchmarks.log > /dev/null ; then
+              exit 1
+          fi
+        
diff --git a/README.md b/README.md
@@ -35,7 +35,7 @@
 </tr>
 <tr>
   <td>Code Quality</td>
-  <td>
+  <td>
     <a href="https://lgtm.com/projects/g/pvlib/pvlib-python/context:python">
     <img src="https://img.shields.io/lgtm/grade/python/g/pvlib/pvlib-python.svg?logo=lgtm&logoWidth=18" alt="lgtm quality grade" />
     </a>
@@ -46,7 +46,7 @@
 </tr>
 <tr>
   <td>Coverage</td>
-  <td>
+  <td>
     <a href="https://coveralls.io/r/pvlib/pvlib-python">
     <img src="https://img.shields.io/coveralls/pvlib/pvlib-python.svg" alt="coveralls coverage" />
     </a>
@@ -55,11 +55,19 @@
     </a>
   </td>
 </tr>
+<tr>
+  <td>Benchmarks</td>
+  <td>
+    <a href="https://pvlib-benchmarker.github.io/pvlib-benchmarks/">
+    <img src="https://img.shields.io/badge/benchmarks-asv-lightgrey" />
+    </a>
+  </td>
+</tr>
 <tr>
   <td>Publications</td>
   <td>
-    <a href="https://doi.org/10.5281/zenodo.3762635">
-    <img src="https://zenodo.org/badge/DOI/10.5281/zenodo.3762635.svg" alt="zenodo reference">
+    <a href="https://doi.org/10.5281/zenodo.593284">
+    <img src="https://zenodo.org/badge/DOI/10.5281/zenodo.593284.svg" alt="zenodo reference">
     </a>
     <a href="http://joss.theoj.org/papers/41187535cad22dd4b076c89b72f874b1">
     <img src="http://joss.theoj.org/papers/41187535cad22dd4b076c89b72f874b1/status.svg" alt="JOSS reference" />
@@ -100,7 +108,7 @@ Installation
 ============
 
 pvlib-python releases may be installed using the ``pip`` and ``conda`` tools.
-Please see the [Installation page](http://pvlib-python.readthedocs.io/en/stable/installation.html) of the documentation for complete instructions.
+Please see the [Installation page](https://pvlib-python.readthedocs.io/en/stable/user_guide/installation.html) of the documentation for complete instructions.
 
 
 Contributing

diff --git a/benchmarks/asv.conf.json b/benchmarks/asv.conf.json
@@ -116,12 +116,12 @@
         {
             "python": "3.6",
             "numpy": "1.16.0",
-            "pandas": "0.22.0",
+            "pandas": "0.25.0",
             "scipy": "1.2.0",
             // Note: these don't have a minimum in setup.py
             "h5py": "2.10.0",
             "ephem": "3.7.6.0",
-            "numba": "0.36.1",
+            "numba": "0.40.0",
         },
         // latest versions available
         {

diff --git a/ci/requirements-py36-min.yml b/ci/requirements-py36-min.yml
@@ -16,7 +16,7 @@ dependencies:
         - dataclasses
         - h5py==3.1.0
         - numpy==1.16.0
-        - pandas==0.22.0
+        - pandas==0.25.0
         - scipy==1.2.0
         - pytest-rerunfailures # conda version is >3.6
         - pytest-remotedata # conda package is 0.3.0, needs > 0.3.1

diff --git a/ci/requirements-py36.yml b/ci/requirements-py36.yml
@@ -11,7 +11,7 @@ dependencies:
     - nose
     - numba
     - numpy >= 1.16.0
-    - pandas >= 0.22.0
+    - pandas >= 0.25.0
     - pip
     - pytest
     - pytest-cov

diff --git a/ci/requirements-py37.yml b/ci/requirements-py37.yml
@@ -11,7 +11,7 @@ dependencies:
     - nose
     - numba
     - numpy >= 1.16.0
-    - pandas >= 0.22.0
+    - pandas >= 0.25.0
     - pip
     - pytest
     - pytest-cov

diff --git a/ci/requirements-py38.yml b/ci/requirements-py38.yml
@@ -11,7 +11,7 @@ dependencies:
     - nose
     - numba
     - numpy >= 1.16.0
-    - pandas >= 0.22.0
+    - pandas >= 0.25.0
     - pip
     - pytest
     - pytest-cov

diff --git a/ci/requirements-py39.yml b/ci/requirements-py39.yml
@@ -11,7 +11,7 @@ dependencies:
     - nose
     # - numba  # python 3.9 compat in early 2021
     - numpy >= 1.16.0
-    - pandas >= 0.22.0
+    - pandas >= 0.25.0
     - pip
     - pytest
     - pytest-cov

diff --git a/docs/examples/iv-modeling/plot_singlediode.py b/docs/examples/iv-modeling/plot_singlediode.py
@@ -103,7 +103,7 @@
 for i, case in conditions.iterrows():
     label = (
         "$G_{eff}$ " + f"{case['Geff']} $W/m^2$\n"
-        "$T_{cell}$ " + f"{case['Tcell']} $C$"
+        "$T_{cell}$ " + f"{case['Tcell']} $\\degree C$"
     )
     plt.plot(curve_info['v'][i], curve_info['i'][i], label=label)
     v_mp = curve_info['v_mp'][i]

diff --git a/docs/sphinx/source/conf.py b/docs/sphinx/source/conf.py
@@ -20,6 +20,9 @@
 # for generating GH links with linenumbers
 import inspect
 
+# import distutils before calling pd.show_versions()
+# https://github.com/pypa/setuptools/issues/3044
+import distutils  # noqa: F401
 import pandas as pd
 pd.show_versions()
 
@@ -244,7 +247,7 @@ def setup(app):
     # In-line links to references as numbers in brackets.
     app.add_css_file("reference_format.css")
     # Add a warning banner at the top of the page if viewing the "latest" docs
-    app.add_javascript("version-alert.js")
+    app.add_js_file("version-alert.js")
 
 # -- Options for LaTeX output ---------------------------------------------
 
@@ -343,8 +346,6 @@ def setup(app):
     'matplotlib': ('https://matplotlib.org/stable', None),
 }
 
-nbsphinx_allow_errors = True
-
 ipython_warning_is_error = False
 
 # suppress "WARNING: Footnote [1] is not referenced." messages

diff --git a/docs/sphinx/source/reference/forecasting.rst b/docs/sphinx/source/reference/forecasting.rst
@@ -3,6 +3,12 @@
 Forecasting
 ===========
 
+.. warning::
+
+    All functionality in the ``pvlib.forecast`` module is deprecated as of
+    pvlib v0.9.1. For details, see :ref:`forecasts`.
+
+
 Forecast models
 ---------------
 

diff --git a/docs/sphinx/source/user_guide/bifacial.rst b/docs/sphinx/source/user_guide/bifacial.rst
@@ -24,7 +24,7 @@ irradiance:
 
 
 pvfactors
-=========
+---------
 
 The `pvfactors <https://sunpower.github.io/pvfactors/>`_ package calculates
 incident irradiance on the front and back surfaces of an array. pvfactors uses
@@ -35,7 +35,7 @@ trackers.
 
 
 Infinite Sheds
-==============
+--------------
 
 The "infinite sheds" model [1] is a 2-dimensional model of irradiance on the
 front and rear surfaces of a PV array. The model assumes that the array

diff --git a/docs/sphinx/source/user_guide/forecasts.rst b/docs/sphinx/source/user_guide/forecasts.rst
@@ -4,6 +4,25 @@
 Forecasting
 ***********
 
+.. warning::
+
+    The ``pvlib.forecast`` module is deprecated as of version ``0.9.1``.
+
+    Because none of the current pvlib team members are able to continue
+    maintaining it, the functionality in ``pvlib.forecast`` is deprecated
+    and will be removed without replacement in a future version.  If you
+    are interested in maintaining this functionality, please let us know.
+
+    You can fetch forecast data yourself using ``siphon`` (see the
+    docs below this warning) and the code from pvlib v0.9.0 as a reference:
+    https://github.com/pvlib/pvlib-python/blob/v0.9.0/pvlib/forecast.py
+
+    The `Solar Forecast Arbiter Core
+    <https://solarforecastarbiter-core.readthedocs.io/en/stable/reference-forecasts.html>`_
+    offers similar (and more robust) forecast processing functionality
+    and may be a suitable replacement for some users.
+
+
 pvlib python provides a set of functions and classes that make it easy
 to obtain weather forecast data and convert that data into a PV power
 forecast. Users can retrieve standardized weather forecast data relevant

diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst
@@ -1,25 +1,26 @@
 .. _whatsnew_0910:
 
-v0.9.1 (TBD)
---------------------------
-
-Breaking changes
-~~~~~~~~~~~~~~~~
+v0.9.1 (March 29, 2022)
+-----------------------
 
 Deprecations
 ~~~~~~~~~~~~
 * Moved :py:func:`pvlib.bifacial.pvfactors_timeseries` to
   :py:func:`pvlib.bifacial.pvfactors.pvfactors_timeseries`.
-  :py:module:`pvlib.bifacial` is now a sub-package. (:pull:`717`)
+  :py:mod:`pvlib.bifacial` is now a sub-package. (:pull:`717`)
 * :py:func:`pvlib.modelchain.basic_chain` is deprecated.
   See :py:meth:`pvlib.modelchain.ModelChain.with_pvwatts` and
   :py:meth:`pvlib.modelchain.ModelChain.with_sapm` for alternative simplified
   :py:class:`~pvlib.modelchain.ModelChain` interfaces, although note that the
   inputs do not directly translate. (:pull:`1401`)
+* All functionality in the ``pvlib.forecast`` module is deprecated.
+  For details, see :ref:`forecasts`. (:issue:`1057`, :pull:`1426`)
 
 Enhancements
 ~~~~~~~~~~~~
-* Added `pvlib.bifacial.infinite_sheds`, containing a model for irradiance
+* Added ``map_variables`` option to :py:func:`pvlib.iotools.get_psm3` and
+  :py:func:`pvlib.iotools.read_psm3` (:pull:`1374`)
+* Added ``pvlib.bifacial.infinite_sheds``, containing a model for irradiance
   on front and back surfaces of bifacial arrays. (:pull:`717`)
 * Added ``map_variables`` option to :func:`~pvlib.iotools.read_crn` (:pull:`1368`)
 * Added :py:func:`pvlib.temperature.prilliman` for modeling cell temperature
@@ -33,7 +34,7 @@ Bug fixes
   values were returned when the sun is behind the plane of array (:issue:`1348`, :pull:`1349`)
 * Fixed bug in :py:func:`pvlib.iotools.get_pvgis_hourly` where the ``optimal_surface_tilt``
   argument was not being passed to the ``optimalinclination`` request parameter (:pull:`1356`)
-* Fixed bug in :py:func:`pvlib.bifacial.pvfactors_timeseries` where scalar ``surface_tilt``
+* Fixed bug in :py:func:`pvlib.bifacial.pvfactors.pvfactors_timeseries` where scalar ``surface_tilt``
   and ``surface_azimuth`` inputs caused an error (:issue:`1127`, :issue:`1332`, :pull:`1361`) 
 * Added -99999 to list of values to map to nan in :func:`~pvlib.iotools.read_crn`
   (:issue:`1372`, :pull:`1368`)
@@ -54,14 +55,19 @@ Documentation
 * Fix documentation return error in :py:meth:`pvlib.forecast.ForecastModel.cloud_cover_to_transmittance_linear`
   (:issue:`1367`, :pull:`1370`)
 * Add gallery example illustrating bifacial simulation using the
-  :py:func:`pvlib.bifacial.pvfactors_timeseries` function and either
+  :py:func:`pvlib.bifacial.pvfactors.pvfactors_timeseries` function and either
   :py:class:`pvlib.modelchain.ModelChain` or procedural functions.
   (:pull:`1394`)
 * Fix some typos (:pull:`1414`)
+* Clarify the descriptions of ``delta_t`` in several solar position functions
+  (:pull:`1429`)
+* Changed $C$ to $\\degree C$ in the plot_singlediode.py file (:pull:`1434`)
 
 Requirements
 ~~~~~~~~~~~~
 * numpy >= 1.16.0 is now required for all python versions. (:pull:`1400`)
+* Fix an installation issue with ``dataclasses`` on python 3.6
+  (:issue:`1302`, :pull:`1422`)
 
 
 Contributors
@@ -76,3 +82,9 @@ Contributors
 * Saurabh Aneja (:ghuser:`spaneja`)
 * Jack Kelly (:ghuser:`JackKelly`)
 * Somasree Majumder(:ghuser:`soma2000-lang`)
+* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)
+* Will Holmgren (:ghuser:`wholmgren`)
+* Mark Mikofksi (:ghuser:`mikofski`)
+* Will Hobbs (:ghuser:`williamhobbs`)
+* Uday Guntupalli (:ghuser:`uguntupalli`)
+* Shashwata Roy (:ghuser:`RoyCoding8`)
diff --git a/docs/sphinx/source/whatsnew/v0.9.2.rst b/docs/sphinx/source/whatsnew/v0.9.2.rst
@@ -0,0 +1,42 @@
+.. _whatsnew_0920:
+
+v0.9.2 (TBD)
+-----------------------
+
+Deprecations
+~~~~~~~~~~~~
+
+Enhancements
+~~~~~~~~~~~~
+
+Bug fixes
+~~~~~~~~~
+* :py:func:`pvlib.irradiance.get_total_irradiance` and
+  :py:func:`pvlib.solarposition.spa_python` now raise an error instead
+  of silently ignoring unknown parameters (:pull:`1437`)
+* Fix a bug in :py:func:`pvlib.solarposition.sun_rise_set_transit_ephem`
+  where passing localized timezones with large UTC offsets could return
+  rise/set/transit times for the wrong day in recent versions of ``ephem``
+  (:issue:`1449`, :pull:`1448`)
+
+
+Testing
+~~~~~~~
+
+Documentation
+~~~~~~~~~~~~~
+
+Benchmarking
+~~~~~~~~~~~~~
+* Updated version of numba in asv.conf from 0.36.1 to 0.40.0 to solve numba/numpy conflict. (:issue:`1439`, :pull:`1440`)
+* Added a basic CI asv check (:issue:`1446`, :pull:`1454`)
+
+Requirements
+~~~~~~~~~~~~
+* Minimum pandas version increased to v0.25.0, released July 18, 2019. (:pull:`1448`)
+
+Contributors
+~~~~~~~~~~~~
+* Naman Priyadarshi (:ghuser:`Naman-Priyadarshi`)
+* Chencheng Luo (:ghuser:`roger-lcc`)
+* Prajwal Borkar (:ghuser:`PrajwalBorkar`)