fix latest NPM packages #8390
Merged
fix latest NPM packages #8390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8322) * fix(walletFactory): move upgrading check before baggage is populated The `baggage.has('walletsByAddress')` check has to come before the `provideDurableMapStore(baggage, 'walletsByAddress')` call. * test(smart-wallet): fake bridge manager detects handler not set ... and handler already set * fixup! test(smart-wallet): fake bridge manager detects handler not set
mhofman
force-pushed
the
mhofman/fix-npm-latest-round-2
branch
from
db5e6cf to
777d079
Compare
Work around babel dep override mistake
Work around babel dep override mistake
mhofman
force-pushed
the
mhofman/fix-npm-latest-round-2
branch
from
777d079 to
9486c77
Compare
…e-mistake Workaround babel override mistake
This was referenced Nov 8, 2023
gibson042
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
The changes look reasonable, and I confirm that the claimed git-rebase-todo is able to produce the resulting commit history and file state.
# Pull Request #8322
pick 97cb7158f fix(walletFactory): move upgrading check before baggage is populated (#8322)
# Pull Request #8351
pick 9f89f97d4 feat: puppetGovernor pass the Issuerkeywordrecord through (#8351)
# Partial Pull Request #7921
pick 1ab049437 build: export tools from swingset-liveslots
# Partial Pull Request #7922
pick 379277e77 fix: export of eslint-config.cjs
# Branch Agoric-mhofman-fix-solo-wallet-ui
label base-Agoric-mhofman-fix-solo-wallet-ui
pick c57885107 fix(solo): correct lookup of wallet-ui
pick 1ac063e79 fix(wallet): don't assume node_modules layout
label Agoric-mhofman-fix-solo-wallet-ui
reset base-Agoric-mhofman-fix-solo-wallet-ui
merge -C bf2e680e7 Agoric-mhofman-fix-solo-wallet-ui # Merge pull request #8392 from Agoric/mhofman/fix-solo-wallet-ui
# Branch Agoric-mhofman-workaround-babel-override-mistake
label base-Agoric-mhofman-workaround-babel-override-mistake
pick 584ec6248 fix(solo): use alternative endo init
pick 877c1a13d fix(internal): severe override taming for bundle-source
label Agoric-mhofman-workaround-babel-override-mistake
reset base-Agoric-mhofman-workaround-babel-override-mistake
merge -C 1831bf3fd Agoric-mhofman-workaround-babel-override-mistake # Merge pull request #8391 from Agoric/mhofman/workaround-babel-override-mistake
Comment on lines
+33
to
+39
| const env = /** @type {NodeJS.ProcessEnv} */ ( | ||
| /** @type {unknown} */ ({ | ||
| __proto__: process.env, | ||
| LOCKDOWN_OVERRIDE_TAMING: 'severe', | ||
| }) | ||
| ); | ||
| const { status } = spawnSync(prog, args, { stdio: 'inherit', env }); |
There was a problem hiding this comment.
TIL that spawnSync etc. walk the prototype chain for env. A comment explaining the insertion of LOCKDOWN_OVERRIDE_TAMING: 'severe' would be nice, but I understand that this is cherry-picking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8380
Description
Follow up to #8360 and #8374. The new NPM packages were not sufficient to get our partner to test a dapp as expected. This PR cherry picks a few more existing and new fixes that were needed. It was not 100% sufficient to run without an agoric-sdk checkout because of their reliance of a cosmos based testnet (see #8033), and makefile targets in
cosmic-swingset, however that's a separate issue.This PR is constructed with the following git-rebase-todo
Security Considerations
This PR picks a change switching the override and error taming of the solo to a severe/unsafe mode respectively. This should be safe as only our trusted code should be impacted.
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Verified these changes applied as patches are sufficient to get KREAd working with their testing flow.
Upgrade Considerations
Only a wallet factory change affects runtime code, however it's only to make it compatible with both a bootstrap and upgrade start, and safe to include even though not technically 100% matching of the code that was deployed in the core eval, but that's what the tag is for. No other contract code is affected.