New user interface (coral) setup #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🙈 Add OS generated files to gitignore.
📝 Add doc for accessibility for coral.
📝 Add doc for frontend testing for coral.
📝 Add doc for documentation for coral.
📝 Add doc for directory structure for coral.
Scaffold react app
Resolves: #110
ESLint was set up using npm init script. Resolves: #110
coral: add static linting
Implemented as described in: https://jestjs.io/docs/webpack#mocking-css-modules Refers: #113
CSS Modules work by default. Refers: #113
feat[coral]: Showcase css modules with example
- remove lint-staged that was accidentally installed on root instead of coral. - add lint-staged package to coral - add script to package.json - update pre-commit script to always change to git-root/coral - use variable for frontend-root to make it easier to change that later - remove echo - use --prefix instead of changing directory
lint-staged passes changed filenames as argument. If files are passed as argument `tsc` does not use tsconfig.json, but CLI inline config. Also run plain prettier and eslint commands with lint-staged. the `pnpm lint` does not use files as argument. Refers: #112
Add precommit hook
- add missing info about pnpm and current state of styling - make text more consistent
Since it's not a part of automated processes, there is no need for it to be a dependency. Instead add a explanation how to use it if wanted. --silent flag is needed, otherwise if there is warning in linting (which we are ok with) the error will bubble up in the terminal and pollute output.
Add coral readme
| # Notes about documentation | ||
|
|
||
| **TL;DR** | ||
| There are many things we may need to discuss at some point in the future, but are not relevant (so much) right now. One things we should start right away is think about and adding [low-level documentation](#Thoughts-about-low-level-documentation) about our code base. We can do that by adding markdown files close to the code (where we need them). This is a low effort start and we can iterate over that approach later, if we need to. |
There was a problem hiding this comment.
One 'thing' we should ..? typo may be
…eadme docs: Update README with info about coral.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.