Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change format of party identifier #376

Merged
merged 7 commits into from
Jan 26, 2024
Merged

feat: change format of party identifier #376

merged 7 commits into from
Jan 26, 2024

Conversation

knuhau
Copy link
Collaborator

@knuhau knuhau commented Jan 23, 2024

Issue #220

@knuhau
Copy link
Collaborator Author

knuhau commented Jan 23, 2024

Script for å oppdatere Party i eksisterende Test-DB, når den tid kommer:

UPDATE public."Dialog"
SET "Party" = 
    CASE
        WHEN "Party" ~ '^/org/\d{9}$' THEN 'urn:altinn:organization:identifier-no::' || substring("Party" from 6)::bigint
        WHEN "Party" ~ '^/person/\d{11}$' THEN 'urn:altinn:person:identifier-no::' || substring("Party" from 9)::bigint
        ELSE "Party"
    END;

@knuhau knuhau changed the title Change format of party identifier feat: change format of party identifier Jan 25, 2024
@knuhau knuhau marked this pull request as ready for review January 25, 2024 12:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oskogstad oskogstad merged commit 27e6744 into main Jan 26, 2024
1 check passed
@oskogstad oskogstad deleted the feature/change-party-identifier branch January 26, 2024 18:42
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Merged
arealmaas pushed a commit that referenced this pull request Feb 28, 2024
@github-actions
chore(main): release 1.0.0 (#497)
a6a91d5 
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2024-02-28)


### Features

* Add element count to eu list dto
([#414](#414))
([934fa93](934fa93))
* Add purge functionallity separate from soft delete.
([#483](#483))
([1349efb](1349efb))
* Add SeenBy per user
([#368](#368))
([c68db9e](c68db9e))
* **azure:** parameterize SKUs
([#364](#364))
([9c27c74](9c27c74))
* change format of party identifier
([#376](#376))
([27e6744](27e6744)),
closes [#220](#220)
* Container app revision verification on deploy
([#392](#392))
([db13a89](db13a89))
* Slack notifier IaC
([#341](#341))
([80c3579](80c3579))


### Bug Fixes

* 412 status on multiple requests without revision header
([#427](#427))
([047cf71](047cf71))
* add APIM base uri for dialogporten
([948b9a4](948b9a4))
* add apim base uri for staging
([#451](#451))
([580d946](580d946))
* add base uri for web api
([#425](#425))
([0aa941b](0aa941b))
* add correct APIM base uri for dialogporten
([713771a](713771a))
* add correct baseuri for altinn events
([#496](#496))
([74940ab](74940ab))
* Add null checks, set lists to empty if null
([#434](#434))
([f264aec](f264aec))
* **azure:** fix postgresql auth config
([#357](#357))
([4a4757f](4a4757f))
* **azure:** remove default value for KEY_VAULT_SOURCE_KEYS
([#418](#418))
([b0d74e8](b0d74e8))
* **azure:** remove default values in params and ensure secure on params
([#415](#415))
([94b9885](94b9885))
* **azure:** rename and fix outputs and pass correct secrets
([#416](#416))
([68f0c8b](68f0c8b))
* build errors for 8.0.200
([#440](#440))
([b133f8f](b133f8f))
* Check Content for null, use DependentRules, disallow empty
localization values
([#413](#413))
([894644a](894644a))
* Correct params for revision verification
([#405](#405))
([4b98348](4b98348))
* Do not allow empty content
([#436](#436))
([a083544](a083544))
* do not prefix swagger document in development
([#491](#491))
([e330ce3](e330ce3))
* remove path to swagger json
([fe1e770](fe1e770))
* rename migration job
([#423](#423))
([3897db2](3897db2))
* restrict container apps to apim ip
([#448](#448))
([1a1f3ad](1a1f3ad))
* Return 410 Gone when updating deleted dialog
([#464](#464))
([2498b0a](2498b0a))
* set base path for swagger json ui
([476fdca](476fdca))
* set base url for swagger json
([#447](#447))
([2161066](2161066))
* shorten secret name for container app job
([#422](#422))
([09b2f30](09b2f30))
* try echoing pgpassword in migration job🤫
([#419](#419))
([fe673a3](fe673a3))
* Use data from events, not from db
([#455](#455))
([469c606](469c606))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MagnusSandgren MagnusSandgren MagnusSandgren left review comments

@oskogstad oskogstad oskogstad approved these changes

@elsand elsand Awaiting requested review from elsand

@arealmaas arealmaas Awaiting requested review from arealmaas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knuhau @MagnusSandgren @oskogstad