reevaluate disablement of strict aliasing warning in chain_plugin

[spoonincode]

leap/plugins/chain_plugin/chain_plugin.cpp

Lines 1709 to 1710 in e401c23

	#pragma GCC diagnostic push
	#pragma GCC diagnostic ignored "-Wstrict-aliasing"

A warning about strict aliasing is probably something that should be tended to, not silenced away.

[larryk85]

This does have the potential of being very bad, so I would say this is one the higher priority tasks and we might want to port any changes needed for this fix to 3.1.x.

In addition to the one place that was found, we should search for more such places in the code that is ignoring warnings. Compiler warnings are usually there for a reason and ignoring them is almost never the valid answer to the problem.

[ericpassmore]

find . -type f ! -name 'test' | xargs egrep "#pragma.*ignored"
./plugins/chain_plugin/chain_plugin.cpp:#pragma GCC diagnostic ignored "-Wstrict-aliasing"
./libraries/chain/include/eosio/chain/config.hpp:#pragma GCC diagnostic ignored "-Wunused-variable"
./libraries/wasm-jit/Source/WAST/ParseNumbers.cpp: #pragma GCC diagnostic ignored "-Wsign-compare"
./libraries/wasm-jit/Source/WAST/ParseNumbers.cpp: #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
./libraries/wasm-jit/Source/WAST/ParseNumbers.cpp: #pragma GCC diagnostic ignored "-Wsign-compare"
./programs/eosio-launcher/main.cpp:#pragma GCC diagnostic ignored "-Wunused-result"
./programs/cleos/CLI11.hpp:#pragma GCC diagnostic ignored "-Wnarrowing"