Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1 -> main] Remove #pragma(s) to ignore warnings #248

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 28, 2022

  • Most of the changes are from the removal of ignoring unused-variables from chain/config.hpp
  • Removed pragma to ignore strict-aliasing from chain_plugin which is the main reason for the changes.
    • Update code to avoid strict-aliasing warning

Resolves #229
Merges #245 into main

@heifner heifner added the OCI Work exclusive to OCI team label Sep 28, 2022
@heifner heifner merged commit 81f016b into main Sep 28, 2022
@heifner heifner deleted the GH-229-warn branch September 28, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reevaluate disablement of strict aliasing warning in chain_plugin
2 participants