[3.1] Remove #pragma(s) to ignore warnings #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin. Also removed pragma to ignore unused-variable from config.hpp. All other changes were to address the removal the ignore unused-variable.
linh2931
reviewed
Sep 27, 2022
| @@ -2054,8 +2054,7 @@ BOOST_AUTO_TEST_CASE(abi_account_name_in_eosio_abi) | |||
| } | |||
| )====="; | |||
|
|
|||
| auto abi = eosio_contract_abi(fc::json::from_string(repeat_abi).as<abi_def>()); | |||
| auto is_type_exception = [](fc::assert_exception const & e) -> bool { return e.to_detail_string().find("abi.types.size") != std::string::npos; }; | |||
There was a problem hiding this comment.
Maybe here we should report error if is_type_exception returns true, instead removing it?
There was a problem hiding this comment.
That is a lambda that is not used. It is copy/pasted from other tests where it is actually used.
unittests/auth_tests.cpp
Outdated
| @@ -341,7 +341,7 @@ BOOST_AUTO_TEST_CASE( any_auth ) { try { | |||
|
|
|||
| const auto spending_priv_key = chain.get_private_key(name("alice"), "spending"); | |||
| const auto spending_pub_key = spending_priv_key.get_public_key(); | |||
| const auto bob_spending_priv_key = chain.get_private_key(name("bob"), "spending"); | |||
| //const auto bob_spending_priv_key = chain.get_private_key(name("bob"), "spending"); | |||
There was a problem hiding this comment.
Why just comment out, not remove?
There was a problem hiding this comment.
I'm NOT a fan of commented out code. But the symmetry with the others made me comment it out instead of remove. I'll go ahead and just remove it.
linh2931
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chain/config.hppstrict-aliasingfromchain_pluginwhich is the main reason for the changes.Resolves #229