Clean up scrape.js #126
Merged
Clean up scrape.js #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix-style line endings (LF) should be the default (as opposed to DOS/Windows style, CRLF), especially considering that none of us needs to use Windows.
Running `git show -bB <commit SHA>` should give a much more manageable diff
There is no need to include "return Promise(...)" in an async function because async/await is syntactic sugar for a Promise-returning function. This caused two or even three layers (if the function given to the Promise constructor was itself async) of nested Promises needlessly.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to improve the formatting and layout of scrape.js.
I would advise that you view each diff separately and with
git show -bB(which excludes whitespace changes).