Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-1621] Reverse order of mobile lineup tile stat icon and number #3759

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

dharit-tan
Copy link
Contributor

@dharit-tan dharit-tan commented Jul 17, 2023

Description

Icon should be first, followed by stat number.
Fixed on both mobile and mobile web.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Screenshot 2023-07-17 at 4 20 54 PM

Simulator Screenshot - iPhone 14 Pro - 2023-07-17 at 16 13 38

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible. Can't believe this bug lived so long!

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/rt-stat-reverse

@dharit-tan dharit-tan merged commit 8a7cbc7 into main Jul 17, 2023
2 checks passed
@dharit-tan dharit-tan deleted the rt-stat-reverse branch July 17, 2023 20:57
dylanjeffers added a commit that referenced this pull request Jul 24, 2023
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers
[9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks
[5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers
[4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed
[5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed
[19cca4c] Change mobile drawer background to white (#3784) Reed
[05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott
[ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott
[46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott
[44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott
[3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott
[bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott
[699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed
[1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell
[79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed
[b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers
[b99b93a] Add fallback url to embed (#3772) Raymond Jacobson
[5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie
[62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers
[9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers
[87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers
[8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson
[9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers
[9c5a412] Remove unused notification announcement page (#3739) Reed
[5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn
[b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed
[40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers
[366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson
[8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed
[9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed
[745ff35] Use Text component in mobile DMs (#3749) Reed
[1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed
[07f0f6c] [PAY-1606] Updates gated content experience  (#3754) Randy Schott
[a82e296] v1.5.32 Dylan Jeffers
dharit-tan pushed a commit that referenced this pull request Jul 24, 2023
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers
[9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks
[5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers
[4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed
[5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed
[19cca4c] Change mobile drawer background to white (#3784) Reed
[05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott
[ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott
[46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott
[44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott
[3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott
[bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott
[699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed
[1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell
[79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed
[b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers
[b99b93a] Add fallback url to embed (#3772) Raymond Jacobson
[5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie
[62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers
[9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers
[87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers
[8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson
[9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers
[9c5a412] Remove unused notification announcement page (#3739) Reed
[5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn
[b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed
[40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers
[366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson
[8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed
[9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed
[745ff35] Use Text component in mobile DMs (#3749) Reed
[1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed
[07f0f6c] [PAY-1606] Updates gated content experience  (#3754) Randy Schott
[a82e296] v1.5.32 Dylan Jeffers
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants