[PAY-1606] Updates gated content experience #3754

schottra · 2023-07-17T15:37:10Z

Description

This is a feature branch containing an updated experience for gated content in anticipation of the upcoming USDC implementation. Track tiles and track details pages have received visual overhauls, and USDC variants have been added behind feature flags. Remaining USDC work will be done iteratively behind the flag.

All code in this branch has been previously reviewed as part of incremental PRs. Check the commit list for more information.

Dragons

It's a big change that should be cosmetic. But there is always some risk with this much code. We can revert if any major issues pop up.

How Has This Been Tested?

Each PR has been tested locally against desktop, mobile web, and native mobile.

How will this change be monitored?

We will be doing a QA pass on staging to verify. Will revert the PR if any major issues pop up.

Feature Flags

All USDC-related features are behind a feature flag that is off by default in production.

…3680)

…3692)

* main: (36 commits) [PAY-1566] Adds support for passing color directly to primary button (#3709) [C-2825] Fix push notification registration (#3672) [C-2827] Fix hidden dog ear on search results (#3708) [C-2830] Move storage node selector to common (#3707) [C-1379] Add link to playlist in mobile toast (#3702) [C-2821] Add hidden dog tag to mobile card (#3701) [C-2587] Fix playlist update tooltip (#3700) [QA-560][PAY-1564] Fix hot and new bug (#3703) [PAY-1563] Fix loading into a chat from a push notification (#3699) [C-2478 C-2480] Add suggestedTracks (#3689) Attach ulid package to window (#3697) Fix track screen artist name font weight (#3695) [C-2416] Fix missing hidden playlists on own profile (#3694) Fetch chats on app foreground (#3693) [C-2718] Fix mobile sign-up environment issues (#3691) Update SDK to v3.0.3-beta.63 (#3688) OAuth and Developer Apps QA C-2816 C-2815 C-2794 C-2793 C-2795 C-2797 (#3681) [C-2465] Improve audius-query cache selection performance (#3687) [C-2799] Disallow protected m4p file uploads (#3686) [PAY-1535] Refresh chat messages on render and pull to refresh on chats list (#3673) ...

… designs (#3717)

… web (#3724)

…3727)

* origin/main: (26 commits) [C-1608 C-2750] Fix edit profile/cover photo (#3735) [C-2711] Remove app-store link in force-upgrade for saga (#3737) Pin lerna version (#3738) Update announcement notification style and hover behavior retry (#3736) [CON-765] Default v2 signup and fix local EM (#3730) Update announcement notification style and hover behavior (#3733) Update announcement notification style and hover behavior (#3733) [C-2844] Ensure all tracks fetched on collection page (#3734) Add dev storage bootstrap nodes (#3731) [QA-565] Fix notification overflow bug (#3732) [C-2547] Lineup pagination fixes (#3728) [C-2679] Track Availability Modal Form (#3720) [C-2785] Update collection screen focus effect to fetch lineup (#3722) Make embed not fetch metadata from CN (#3710) [C-2809] Remove user from image hooks (#3723) [C-2834] Remove replica set usage in web (#3721) [C-2829] Finalize SuggestedTracks (#3706) [PAY-1569] Update blog post link (#3719) Call the DN selection callback in AudiusBackend if using a cached DN (#3718) DMs: Add space to learn more text (#3714) ...

)

* origin/main: Manually set the libs state to prevent retry storm (#3753) Fix android announcement notifs (#3750) [PAY-1599] Fix font in Start Conversation prompt (#3748) [C-2851] Add privacy policy to settings page (#3741) [PAY-1595] Hide chat textinput until chat exists (#3746) [PAY-1597] Fix mobile chat screen empty state font (#3744) Bump Android again (#3745) Get the first storage node for o-auth not all of them (#3743) Bump app versions (#3742) Notification cursor reflects clickability (#3740) [C-2823] Improve autogenerated image logic (#3729)

gitguardian · 2023-07-17T15:37:16Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
1606949	Generic High Entropy Secret	`274f836`	packages/web/.env/.env.prod	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

audius-infra · 2023-07-17T15:54:56Z

Preview this change https://demo.audius.co/gated-content-updates

dharit-tan

approving this so we can merge for testing.
Also, should we not squash these commits?

schottra · 2023-07-17T16:25:38Z

@dharit-tan

Also, should we not squash these commits?

I was planning to do "Squash and Merge" on the PR, which should result in a single commit with the PRs as a comment. Any concerns with that approach?

audius-infra · 2023-07-17T16:30:06Z

Preview this change https://demo.audius.co/gated-content-updates

schottra · 2023-07-17T18:54:08Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

Discussed this offline. It's a false alarm generated by a whitespace change on main in a file that exports constants which appear to be secrets.

[72ec48f] Upgrade to 1.5.33 Dylan Jeffers [9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks [5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers [4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed [5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed [19cca4c] Change mobile drawer background to white (#3784) Reed [05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott [ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott [46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott [44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott [3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott [bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott [699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed [1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell [79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed [b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers [b99b93a] Add fallback url to embed (#3772) Raymond Jacobson [5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie [62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers [9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers [87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers [8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson [9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers [9c5a412] Remove unused notification announcement page (#3739) Reed [5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn [b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed [40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers [366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson [8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed [9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed [745ff35] Use Text component in mobile DMs (#3749) Reed [1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed [07f0f6c] [PAY-1606] Updates gated content experience (#3754) Randy Schott [a82e296] v1.5.32 Dylan Jeffers

dharit-tan and others added 21 commits June 29, 2023 11:10

[PAY-1545] Updates to mobile gated content track tiles (#3663)

c129aec

[PAY-1504] Update gated content track tiles on web (#3677)

9858216

[PAY-1549] Gated content track screen updates (#3676)

250eb53

[PAY-1504] Remove most usage of gated content feature flags on web (#…

cd7b3d9

…3680)

Finish implementation of typography CSS module (#3683)

001fe68

[PAY-1505] USDC-gated mobile track tiles (#3684)

f4a7c7d

Migrate getDogEarType to common (#3685)

8080665

[PAY-1556] Update mobile web gated content experience for TrackTiles (#…

6373b87

…3692)

Mobile gated content updates pt. 2 (#3696)

0271719

Convert GiantTrackTile to typescript (#3698)

468f848

Minor fixes for premium_content + usdc purchases (#3705)

fae248f

[PAY-1513][PAY-1557] Update track details page with new gated content…

d68b252

… designs (#3717)

[PAY-1573] Convert premium content type to union (#3711)

54371aa

[PAY-1559][PAY-1560] Adds USDC variants for track tiles on web/mobile…

53e815a

… web (#3724)

[PAY-1514] Mobile USDC track screen changes (#3725)

9bdf9f6

Remove gated content feature flags from mobile (#3726)

a241db8

[PAY-1561][PAY-1558] Implement USDC variants on track details page (#…

df3302d

…3727)

[PAY-1578] Hide USDC-gated tracks if the feature flag is disabled (#3752

b4854a1

)

schottra requested review from dharit-tan, piazzatron and dylanjeffers July 17, 2023 15:37

pull-request-size bot added the size/XXL label Jul 17, 2023

schottra assigned rickyrombo, sddioulde and sliptype Jul 17, 2023

use context for getFeatureEnabled

099dd73

dharit-tan approved these changes Jul 17, 2023

View reviewed changes

schottra merged commit 07f0f6c into main Jul 17, 2023
2 checks passed

schottra deleted the gated-content-updates branch July 17, 2023 19:47

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-1606] Updates gated content experience #3754

[PAY-1606] Updates gated content experience #3754

schottra commented Jul 17, 2023

gitguardian bot commented Jul 17, 2023 •

edited

Loading

audius-infra commented Jul 17, 2023

dharit-tan left a comment •

edited

Loading

schottra commented Jul 17, 2023 •

edited

Loading

audius-infra commented Jul 17, 2023

schottra commented Jul 17, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

[PAY-1606] Updates gated content experience #3754

[PAY-1606] Updates gated content experience #3754

Conversation

schottra commented Jul 17, 2023

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

gitguardian bot commented Jul 17, 2023 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

audius-infra commented Jul 17, 2023

dharit-tan left a comment • edited Loading

Choose a reason for hiding this comment

schottra commented Jul 17, 2023 • edited Loading

audius-infra commented Jul 17, 2023

schottra commented Jul 17, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

gitguardian bot commented Jul 17, 2023 •

edited

Loading

dharit-tan left a comment •

edited

Loading

schottra commented Jul 17, 2023 •

edited

Loading